[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: resurrecting kwrited
From: "Michael Howell" <mhowell123 () gmail ! com>
Date: 2008-10-14 15:00:38
Message-ID: a2927be10810140800p6cec1d1jd01b4fc315d4067a () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> - add DBus Interface?
No. That is what KNotify is for.
On 10/14/08, George Kiagiadakis <kiagiadakis.george@gmail.com> wrote:
>
> 2008/10/13 Oswald Buddenhagen <ossi@kde.org>:
>
> >> Also, this slotData() doesn't do anything different, it just uses
> >> read(2) to read data into a buffer.
> >>
> > ****** huh?
>
>
> I think I get the point now, that kconsole class does exactly the same
> job as kwrited but with a different terminal device. What I don't get
> is, do I have to revert that commit and use the read system call
> directly? Isn't there another way? That's probably bad, but well, I'll
> do it.
>
>
> >> > 7f8825dff376b5df7f5fbd8afa298a29f7084d04
> >> > - hmpf. this is bad bad bad. oh, well.
> >>
> >> Why? kwrited is completely useless without libutempter and it justs
> >> wastes memory.
> >>
> > yes, but it should not be. you realized that, after all. :)
>
>
> I know, but in case we don't build kwrited as an executable, it's
> better not to build it at all. This commit of course applies only to
> the master branch, not to the no-utempter branch.
>
>
> >> I did not write any cmake code to setgid kwrited as I couldn't find
> >> how to do chown from cmake.
> >>
> > kworkspace/kcheckpass/
>
>
> Thanks, fixed now.
>
> Other news now. I dropped the textedit and only knotify is used. That
> reduces a lot the memory footprint of kwrited if it is built as an
> executable, but still I can't get rid of kdeui as KNotification lives
> in kdeui... :( (why is that, btw?) The repository now only has two
> branches, master and no-utempter. Their only difference is that the
> no-utempter branch includes building kwrited as an executable and
> installing it with setgid.
>
> Tell me if I need to fix something else. Btw, does anybody have an
> idea what those items in the TODO comment in kwrited.cpp mean? I think
> they are pretty useless... Here:
> /* TODO
> for anyone who likes to do improvements here, go ahead.
> - check FIXMEs below
> - add Menu
> - accept messages (on/off)
> - pop up on incoming messages
> - allow max. lines
> - add DBus interface?
> - add session awareness.
> - add client complements.
> */
>
> Regards,
>
> George
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
--
Michael Howell
mhowell123@gmail.com
[Attachment #5 (text/html)]
> - add DBus Interface?<br>No. That is what KNotify is for.<br><br><br><div><span \
class="gmail_quote">On 10/14/08, <b class="gmail_sendername">George Kiagiadakis</b> \
<<a href="mailto:kiagiadakis.george@gmail.com">kiagiadakis.george@gmail.com</a>> \
wrote:</span><blockquote class="gmail_quote" \
style="margin:0;margin-left:0.8ex;border-left:1px #ccc solid;padding-left:1ex"> \
2008/10/13 Oswald Buddenhagen <<a \
href="mailto:ossi@kde.org">ossi@kde.org</a>>:<br> <br>>> Also, this \
slotData() doesn't do anything different, it just uses<br> >> read(2) to \
read data into a buffer.<br> >><br> > ****** huh?<br> <br> <br>I think I \
get the point now, that kconsole class does exactly the same<br> job as kwrited but \
with a different terminal device. What I don't get<br> is, do I have to revert \
that commit and use the read system call<br> directly? Isn't there another way? \
That's probably bad, but well, I'll<br> do it.<br> <br><br> >> > \
7f8825dff376b5df7f5fbd8afa298a29f7084d04<br> >> > - hmpf. this is bad bad \
bad. oh, well.<br> >><br> >> Why? kwrited is completely useless without \
libutempter and it justs<br> >> wastes memory.<br> >><br> > yes, but \
it should not be. you realized that, after all. :)<br> <br> <br>I know, but in case \
we don't build kwrited as an executable, it's<br> better not to build it at \
all. This commit of course applies only to<br> the master branch, not to the \
no-utempter branch.<br> <br><br> >> I did not write any cmake code to setgid \
kwrited as I couldn't find<br> >> how to do chown from cmake.<br> \
>><br> > kworkspace/kcheckpass/<br> <br> <br>Thanks, fixed now.<br> <br> \
Other news now. I dropped the textedit and only knotify is used. That<br> reduces a \
lot the memory footprint of kwrited if it is built as an<br> executable, but still I \
can't get rid of kdeui as KNotification lives<br> in kdeui... :( (why is that, \
btw?) The repository now only has two<br> branches, master and no-utempter. Their \
only difference is that the<br> no-utempter branch includes building kwrited as an \
executable and<br> installing it with setgid.<br> <br> Tell me if I need to fix \
something else. Btw, does anybody have an<br> idea what those items in the TODO \
comment in kwrited.cpp mean? I think<br> they are pretty useless... Here:<br> /* \
TODO<br> for anyone who likes to do improvements here, go \
ahead.<br> - check FIXMEs below<br> - add \
Menu<br> - accept messages \
(on/off)<br> - pop up on incoming messages<br> \
- allow max. lines<br> - add DBus \
interface?<br> - add session awareness.<br> - add client \
complements.<br> */<br> <br> Regards,<br> <br>George<br> <br><br> >> Visit <a \
href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> \
to unsubscribe <<<br> </blockquote></div><br><br clear="all"><br>-- \
<br>Michael Howell<br><a href="mailto:mhowell123@gmail.com">mhowell123@gmail.com</a>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic