[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: which module would be most appropriate for my library?
From:       "Ben Cooksley" <sourtooth () gmail ! com>
Date:       2008-08-27 9:54:16
Message-ID: b366d7a00808270254n87d5d76ne4bf3f3c45d73a60 () mail ! gmail ! com
[Download RAW message or body]

hi ( again ),
the setters are now void, changed with commit #853130.
they were originally bool as it was designed to indicate whether the
operation succeeded or not. now its up to the application developer to
double check with the appropriate get method, which shouldn't even be
needed ( unless they are paranoid, or like being very safe :) )
the includes are also fixed with #853131 as per the library code policy.

thanks for the observations,
bcooksley


On 8/27/08, Richard Moore <richmoore44@gmail.com> wrote:
> On 8/27/08, Ben Cooksley <sourtooth@gmail.com> wrote:
>> On 8/27/08, Aaron J. Seigo <aseigo@kde.org> wrote:
>> > On Tuesday 26 August 2008, Ben Cooksley wrote:
>> >> i think that i am ready to move from development stage 1 to stage 2,
>
> Another issue is that most of the header files included by
> kosdwidget.h can be removed and replaced with forward declarations.
> This will speed up compilation, the headers only need to be included
> by the .cpp file.
>
> Methods like:
> bool loadImage( QPixmap content );
> and
> bool setText( QString content );
> should take a const reference instead this:
> bool loadImage( const QPixmap &content );
> bool setText( const QString &content );
>
> a further thing that we don't normally make setters return anything,
> why are these not void?
>
> Cheers
>
> Rich.
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>>> <<
>
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]