[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Still possible to commit new features for 3.5.5 ?
From:       Juan Luis Baptiste <juan.baptiste () kdemail ! net>
Date:       2006-09-22 2:24:26
Message-ID: 200609212124.26668.juan.baptiste () kdemail ! net
[Download RAW message or body]

On Thursday 21 September 2006 06:31, Stephan Kulow wrote:
> >
> > https://bugs.kde.org/show_bug.cgi?id=133744
> >
> > But I don't know if I can commit it or I have to wait after the release
> > to do it.
>
> How does the patch look like? 133744 sounds like a bug to me and it doesn't
> seem to require docu or translation updates. So if the patch is easy to
> review, I'd approve it.
>

I reported it as a bug but the component owner decided to change it to a 
whishlist item. Here it is:

In kdebase/kdialog:

Index: progressdialogiface.h
===================================================================
--- progressdialogiface.h       (revision 587244)
+++ progressdialogiface.h       (working copy)
@@ -18,6 +18,7 @@

     virtual void showCancelButton ( bool ) =0;
     virtual bool wasCancelled() const =0;
+    virtual void dontCancel() =0;

     virtual void setAutoClose( bool ) =0;
     virtual bool autoClose() const =0;
Index: progressdialog.cpp
===================================================================
--- progressdialog.cpp  (revision 587244)
+++ progressdialog.cpp  (working copy)
@@ -85,4 +85,8 @@
     slotClose();
 }

+void ProgressDialog::dontCancel()
+{
+    KProgressDialog::dontCancel();
+}
 #include "progressdialog.moc"
Index: progressdialog.h
===================================================================
--- progressdialog.h    (revision 587244)
+++ progressdialog.h    (working copy)
@@ -39,6 +39,7 @@

       void showCancelButton(bool show);
       bool wasCancelled() const;
+      void dontCancel();

       void setAutoClose( bool );
       bool autoClose() const;


In kdelibs/kdeui:

Index: kdeui/kprogress.cpp
===================================================================
--- kdeui/kprogress.cpp (revision 587244)
+++ kdeui/kprogress.cpp (working copy)
@@ -233,6 +233,11 @@
     return mCancelled;
 }

+void KProgressDialog::dontCancel()
+{
+    mCancelled = false;
+}
+
 bool KProgressDialog::wasCancelled() const
 {
     return mCancelled;
Index: kdeui/kprogress.h
===================================================================
--- kdeui/kprogress.h   (revision 587244)
+++ kdeui/kprogress.h   (working copy)
@@ -327,6 +327,13 @@
         bool wasCancelled() const;

         /**
+         * Cancels the last "cancel" action if the cancel button was
+         * pressed. Useful for kdialog when combined with a KMessageBox
+         * to display a message like "Are you sure you want to cancel?"
+         */
+        void dontCancel();
+
+        /**
          * Sets the text to appear on the cancel button.
          */
         void setButtonText(const QString&);

I'm not sure about the dontCancel name for the method but I couldn't come up 
with a better one.

Cheers,
-- 
Juan Luis Baptiste
http://www.merlinux.org
http://knetworkconf.sf.net
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]