[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    RE: [PATCH] Fix crash of KDE Accessibility tool on KDE startup
From:       Dave Rowe <dave () roweware ! com>
Date:       2006-03-19 15:37:57
Message-ID: 93187b9b732c75f8a773bb695864e3fe () localhost
[Download RAW message or body]

I apologize if this is too soon of a follow-up.

Is anyone else experiencing the crash of KDE Accessibility Tool on
KDE Startup?  I compiled libs and base from the latest 3.5 branch,
and I'm seeing it crash.  I think this may need to be addressed before
3.5.2 is released, as this may cause significant bug reports.

Please review.  It may seem like a trivial patch / fix, but it
appears, to me, to be necessary.

Thanks,
Dave

-------- Original Message --------
Subject: [PATCH] Fix crash of KDE Accessibility tool on KDE startup
Date: Sat, 18 Mar 2006 11:54:44 -0700
From: Dave Rowe <dave@roweware.com>
To: kde-devel@kde.org

Hello,
It appears that in SVN on the 3.5 branch, a mistake in the logic of a for loop
may be causing the KDE Accessibility tool to crash on startup of KDE.

I believe the attached patch fixes this crash.

Please review and let me know if it's okay to commit.

Thanks,
Dave
dave@roweware.com

-- 
Dave
dave@roweware.com
["kaccess_cpp.patch" (application/octet-stream)]

Index: kcontrol/access/kaccess.cpp
===================================================================
--- kcontrol/access/kaccess.cpp (revision 520063)
+++ kcontrol/access/kaccess.cpp (working copy)
@@ -337,7 +337,7 @@
       keys [i] = -1;
    state = 0;

-   for (int i = 0; modifierKeys[i].name; i++) {
+   for (int i = 0; strcmp(modifierKeys[i].name, ""); i++) {
       int mask = modifierKeys[i].mask;
       if (mask == 0)
          if (modifierKeys[i].keysym != 0)

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]