[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] Fix crash of KDE Accessibility tool on KDE startup
From:       Dave Rowe <dave () roweware ! com>
Date:       2006-03-18 18:54:44
Message-ID: 0aa2662d78f03887eb53b14728c5ab48 () localhost
[Download RAW message or body]

Hello,
It appears that in SVN on the 3.5 branch, a mistake in the logic of a for loop may be 
causing the KDE Accessibility tool to crash on startup of KDE.

I believe the attached patch fixes this crash.

Please review and let me know if it's okay to commit.

Thanks,
Dave
dave@roweware.com
["kaccess_cpp.patch" (application/octet-stream)]

Index: kcontrol/access/kaccess.cpp
===================================================================
--- kcontrol/access/kaccess.cpp (revision 520063)
+++ kcontrol/access/kaccess.cpp (working copy)
@@ -337,7 +337,7 @@
       keys [i] = -1;
    state = 0;

-   for (int i = 0; modifierKeys[i].name; i++) {
+   for (int i = 0; strcmp(modifierKeys[i].name, ""); i++) {
       int mask = modifierKeys[i].mask;
       if (mask == 0)
          if (modifierKeys[i].keysym != 0)

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]