[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] kdelibs/kparts <-> kget
From:       David Faure <faure () kde ! org>
Date:       2005-12-27 11:17:17
Message-ID: 200512271217.18595.faure () kde ! org
[Download RAW message or body]

On Sunday 25 December 2005 19:46, Rainer Wirtz wrote:
> Hi,
> While trying to fix http://bugs.kde.org/show_bug.cgi?id=117970 I ran 
> into a problem:
> When clicking "Save as.." in konquerors "Save as.../open/cancel" dialog, 
> then kget is called with the url as first argument and an empty second 
> argument. This breaks my intended fix.
> 
> The attached patch for kdelibs/kparts/browserrun.cpp fixes this problem.
> 
> OK to commit?

The idea is fine; the patch duplicates the adding of the url, why not do this instead?

-                cmd += " " + KProcess::quote(url.url()) + " " + KProcess::quote(suggestedFilename);
+                cmd += " " + KProcess::quote(url.url());
+                if ( !suggestedFilename.isEmpty() )
+                    cmd += " " + KProcess::quote(suggestedFilename);

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]