[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] kdelibs/kparts <-> kget
From:       Rainer Wirtz <rainer.wirtz () gmx ! de>
Date:       2005-12-25 18:46:07
Message-ID: 200512251946.07202.rainer.wirtz () gmx ! de
[Download RAW message or body]

Hi,
While trying to fix http://bugs.kde.org/show_bug.cgi?id=117970 I ran 
into a problem:
When clicking "Save as.." in konquerors "Save as.../open/cancel" dialog, 
then kget is called with the url as first argument and an empty second 
argument. This breaks my intended fix.

The attached patch for kdelibs/kparts/browserrun.cpp fixes this problem.

OK to commit?

Rainer

Oh, this is for the 3.5 branch

["kdelibs_save_as.patch" (text/x-diff)]

Index: kparts/browserrun.cpp
===================================================================
--- kparts/browserrun.cpp	(Revision 488502)
+++ kparts/browserrun.cpp	(Arbeitskopie)
@@ -394,7 +394,10 @@
                 // the duplicated code) with shiny new KDownload class for 3.2 (pfeiffer)
                 // Until the shiny new class comes about, send the suggestedFilename
                 // along with the actual URL to download. (DA)
-                cmd += " " + KProcess::quote(url.url()) + " " + KProcess::quote(suggestedFilename);
+                if ( suggestedFilename.isEmpty() )
+                    cmd += " " + KProcess::quote(url.url());
+                else
+                    cmd += " " + KProcess::quote(url.url()) + " " + KProcess::quote(suggestedFilename);
                 kdDebug(1000) << "Calling command  " << cmd << endl;
                 // slave is already on hold (slotBrowserMimetype())
                 KIO::Scheduler::publishSlaveOnHold();


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]