[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] kdelibs/kparts <-> kget
From:       Rainer Wirtz <rainer.wirtz () gmx ! de>
Date:       2005-12-27 16:36:26
Message-ID: 200512271736.26332.rainer.wirtz () gmx ! de
[Download RAW message or body]

Am Di Dezember 27 2005 12:17 schrieb David Faure:

> The idea is fine; the patch duplicates the adding of the url, why not
> do this instead?
>
> -                cmd += " " + KProcess::quote(url.url()) + " " +
> KProcess::quote(suggestedFilename); +                cmd += " " +
> KProcess::quote(url.url());
> +                if ( !suggestedFilename.isEmpty() )
> +                    cmd += " " + KProcess::quote(suggestedFilename);

Yes, this is better, I'll commit tomorrow (gotta go)

Rainer
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]