[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Old kicker bug that can be closed
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2005-04-01 23:15:57
Message-ID: 200504011616.04491.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 01 April 2005 02:47, Baris Metin wrote:
> Fri, Apr 01, 2005 at 09:08:09AM -0700 , Aaron J. Seigo :
> > On Friday 01 April 2005 06:49, Barış Metin wrote:
> > > I've prepared a 3.4.0 patch which adds text to the K menu button, based
> > > on Linspire's patches.
> >
> > how does this now look:
> >
> > 	o in right-to-left?
>
> Haven't tried, but my bet is negative. Does using QChar::direction() is
> appropriate way of getting bidi status?

bool QApplication::reverseLayout()

> > 	o with a background tile set in the configuration panel?
>
> Ignoring background tile sound a good idea at first. That's how it work
> for now.

hum ... well, that'll cause bug reports for those who set that in the config. 
in KDE4, those tiles are going away, but for now they are there. it would 
also prevent putting this in PanelButton itself (where it belongs IMHO). how 
about keeping the tile under the icon and leaving the text as-is for now 
(e.g., no tile under the text)? 

in fact, just paint the tile on the left (or right, in reverseLayout()) so 
that people can provide a really wide tile for the Lindows effect.

> > 	o transparent?
>
> Problem is, if the desktop background is the same colour with
> the text it is unreadable. Maybe we can go to the desktop icons' way
> adding shadow to the text?

that's exactly what will have to happen =) glad we're on the same page.

> > 	o when in a panel placed on the left or right of the panel?
>
> Order of the pixmap and text doesn't change.

sorry, i made a typo. what happens when the _panel_ is placed on the left or 
right edge of the _screen_. e.g. on vertical panels?

> > i'm interested in such a patch, but it has to work in all the above
> > situations too.
>
> Hope we can find solutions, I'll try to work on the patch after getting
> your opinions.

awesome =)

> > i'd also probably put the support for this in the PanelButton class if
> > you haven't already so that other buttons that may wish the same
> > behaviour can easily access it.
>
> Haven't done, but it's a good idea :).

well, if you can make it work in the K Button, i don't mind porting it down to 
the PanelButton class myself.

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]