[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Intended behavior of "File Already Exists" dialog box?
From:       "Steven P. Ulrick" <ulrick2 () faith4miracle ! org>
Date:       2004-10-27 10:05:29
Message-ID: 200410270505.29642.ulrick2 () faith4miracle ! org
[Download RAW message or body]

On Wednesday 27 October 2004 04:19 am, David Faure wrote:
> On Wednesday 27 October 2004 06:29, Steven P. Ulrick wrote:
> > On Tuesday 26 October 2004 05:39 pm, David Faure wrote:
> > > I see. This is due to the (new since a few releases) code which tries
> > > to do a direct renaming before launching the full "copy + delete"
> > > operation. That code has its own "rename dialog" code, and I didn't
> > > want to use the "multiple files" and "skip" flags for it.... for a
> > > reason that I don't understand anymore (confusing comment).
> > >
> > > So I added it now.
> > > Testing showed that "skip" was broken (it crashed often), so I fixed
> > > that too.
> > >
> > > There are chances I still missed something though, there are so many
> > > cases... Care to test the attached patch (for CVS HEAD) ?
> >
> > Hello, David
> > The patch applied just fine, and I recompiled and installed kdelibs, and
> > I got my beloved "Skip" and "Auto Skip" back :)
> > There is one problem that I discovered right away: let's say I have seven
> > files I want to move into a directory that may already have some or all
> > of them in it.  I select the desired files, drag them to the directory,
> > and choose to "Move" them to that location.  I choose to skip a few, and
> > I choose to overwrite a few.  The last one happens to be one that I want
> > to skip.  So, I click "Cancel", and a few seconds later, I find that none
> > of the files that I had wanted to move to that other directory were
> > moved.  All the files I started with are still in their original
> > location.
>
> You're a good tester - I also thought about this bug when going to bed last
> night :) Easily fixed,
>                 if ( m_srcList.count() > 1 )
>                     mode = (RenameDlg_Mode) ( mode | M_MULTI | M_SKIP );
>                 else
>                     mode = (RenameDlg_Mode) ( mode | M_SINGLE );
> (the first line was different).

Hello, David
My above mentioned issue appears to be fixed with your above quoted changes.  
If I should find any other issues, I will let you know.

Steven P. Ulrick
-- 
 05:03:43 up 14 days, 14:33, 30 users,  load average: 2.56, 3.43, 3.29
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]