[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: dirtree_module and URLs with passwords
From:       Jakub Stachowski <stachowski () hypair ! net>
Date:       2004-10-24 17:51:54
Message-ID: 200410241951.55289.stachowski () hypair ! net
[Download RAW message or body]

Dnia sobota, 23 pa=BCdziernika 2004 12:25, Jakub Stachowski napisa=B3:
> Dnia sobota, 23 pa=BCdziernika 2004 10:25, David Faure napisa=B3:
> > On Friday 22 October 2004 18:26, Jakub Stachowski wrote:
> > > Hello,
> > >
> > > dirtree_module from kdebase/konqueror/sidebar/trees/dirtree_module
> > > currently breaks on URLs with passwords. For example redirection from
> > > dnssd://_ftp._tcp/some service to ftp://user:pass@host/ results in
> > > "Cannot find parent item URL in the tree. Internal error.". This is
> > > because all URLs are inserted into dictionary with passwords, but
> > > searched for (in slotNewItems) without - so keys don't match. Password
> > > is stripped at dirtree_module.cpp:393 , just before dictionary lookup.
> > > Is there any reason for doing this? If not, can I remove this line?
> >
> > cvs annotate has the answer to your question...
> >
> > 1.9          (faure    06-Nov-01):     dir.setPass( QString::null );
> >
> > revision 1.9
> > date: 2001/11/06 02:43:41;  author: faure;  state: Exp;  lines: +1 -0
> > Fixed #34557 (ftp urls with pass in the url -> crash)
>
> I followed the bugreport and on 3.2.3 (Mandrake), 3.3.0 (Debian) and rece=
nt
> CVS this bug is back (it is exactly the same thing that I described above=
).
> Funny thing is that reverting fix from rev 1.9 solves the problem.
>

I see no further comments on this issue. So is it ok to commit and fix it?

["dirtree.patch" (text/x-diff)]

--- dirtree_module.cpp.old	2004-10-24 19:49:26.000000000 +0200
+++ dirtree_module.cpp	2004-10-24 19:47:46.000000000 +0200
@@ -390,7 +390,6 @@
     // Find parent item - it's the same for all the items
     KURL dir( firstItem->url().url(-1) );
     dir.setFileName( "" );
-    dir.setPass( QString::null );
     kdDebug(1201) << this << " KonqSidebarDirTreeModule::slotNewItems dir=" << dir.url(-1) << endl;
 
     QPtrList<KonqSidebarTreeItem> *parentItemList;


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]