[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Problem with Transparent Menus - CVS HEAD
From:       Michael Pyne <pynm0001 () comcast ! net>
Date:       2004-06-25 21:41:05
Message-ID: 200406251741.11392.pynm0001 () comcast ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 25 June 2004 16:48, Michael Pyne wrote:
> I can confirm this bug as well.  It seems to be a duplicate of bug 83147
> (which was itself marked as a duplicate).  I suspect a change in kdefx may
> have done this, I'll try to figure it out.

Please apply the attached patch in kdelibs/kdefx by running
$ patch < fix-trans.patch

and then rebuilding and reinstalling kdelibs.  You should probably restart KDE 
to be sure the changes are in effect as well.  This patch fixes the problem 
over on my system.

Regards,
 - Michael Pyne
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA3Jv0qjQYp5Omm0oRAgyqAKCngc3AYHLSll8cmHvj3bgVKr8UhwCfSPHX
rydVhi50EBCJv0+LKDjw+lE=
=czC9
-----END PGP SIGNATURE-----

["fix-trans.patch" (text/x-diff)]

Index: kimageeffect.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdefx/kimageeffect.cpp,v
retrieving revision 1.54
diff -u -3 -p -r1.54 kimageeffect.cpp
--- kimageeffect.cpp	21 Jun 2004 02:14:16 -0000	1.54
+++ kimageeffect.cpp	25 Jun 2004 21:35:55 -0000
@@ -2202,32 +2202,20 @@ QImage& KImageEffect::contrast(QImage &i
         g = qGreen(data[i]);
         b = qBlue(data[i]);
         if(qGray(data[i]) <= 127){
-            if(r - c > 0)
+            if(r - c <= 255)
                 r -= c;
-            else
-                r = 0;
-            if(g - c > 0)
+            if(g - c <= 255)
                 g -= c;
-            else
-                g = 0;
-            if(b - c > 0)
+            if(b - c <= 255)
                 b -= c;
-            else
-                b = 0;
         }
         else{
             if(r + c <= 255)
                 r += c;
-            else 
-                r = 255;
             if(g + c <= 255)
                 g += c;
-            else
-                g = 255;
             if(b + c <= 255)
                 b += c;
-            else
-                b = 255;
         }
         data[i] = qRgba(r, g, b, qAlpha(data[i]));
     }


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]