[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Konq Render Error
From:       Robert Shade <ras319 () psu ! edu>
Date:       2002-04-04 7:05:59
[Download RAW message or body]

>> Hi all,
>> 
>> Just noticed this.  Is there any reason that when you left click on the 
>> rendering window in Konqueror the copy button becomes available?  You don't 
>> have to click on text or anything, just click anywhere (not on a link of 
>> course) and the copy button will become available, but release the button 
>and 
>> it grays again.  I didn't know if there was any technical reason why this 
>> should be, it was just kind of strange.

>It is. But it's minor so nobody fixed it. Where's the patch?

Attached to this email. :)  I think this is a correct solution for this 
problem.  Also in the patch are a few missed variable initializations, I've 
always been taught that these are "a good thing to do all the time".  If I've 
been misinformed, please disregard.

Also, I noticed another bug while playing with this. If you click in an area 
that is not a rendered object (I think this is the correct terminology) like 
in the whitespace between the end of stories and the "Read more..." hyperlink 
on slashdot and then try to select the text above it, the text will not be 
hilighted as you select it.  Interestingly though, if you look at klipper 
after you do this, the text that you were trying to select has indeed been 
selected, but selected twice.  (it appears twice in klipper)  I'm going to 
look furthur into this problem and hopefully have a patch in the next few 
days.

Thanks.

Robert Shade
["khtml.diff" (text/x-diff)]

Index: khtml_part.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtml_part.cpp,v
retrieving revision 1.684
diff -u -3 -p -r1.684 khtml_part.cpp
--- khtml_part.cpp	24 Mar 2002 23:10:02 -0000	1.684
+++ khtml_part.cpp	4 Apr 2002 06:48:03 -0000
@@ -1445,7 +1445,7 @@ void KHTMLPart::slotLoaderRequestDone( k
 
 void KHTMLPart::slotProgressUpdate()
 {
-  int percent;
+  int percent = 0;
   if ( d->m_loadedObjects < d->m_totalObjectCount )
     percent = d->m_jobPercent / 4 + ( d->m_loadedObjects*300 ) / ( 4*d->m_totalObjectCount );
   else
@@ -3196,7 +3196,7 @@ void KHTMLPart::restoreState( QDataStrea
   d->m_encoding = encoding;
   d->m_sheetUsed = sheetUsed;
 
-  int zoomFactor;
+  int zoomFactor = 0;
   stream >> zoomFactor;
   setZoomFactor(zoomFactor);
 
@@ -3628,7 +3628,7 @@ void KHTMLPart::khtmlMousePressEvent( kh
         d->m_selectionStart = DOM::Node();
         d->m_selectionEnd = DOM::Node();
       }
-      emitSelectionChanged();
+      emit selectionChanged();
       startAutoScroll();
     }
 #else
@@ -3715,7 +3715,7 @@ void KHTMLPart::khtmlMouseMoveEvent( kht
           khtml::RenderObject *r = i->renderer();
           if(r)
           {
-            int absx, absy, vx, vy;
+            int absx = 0, absy = 0, vx = 0, vy = 0;
             r->absolutePosition(absx, absy);
             view()->contentsToViewport( absx, absy, vx, vy );
 
@@ -3753,7 +3753,7 @@ void KHTMLPart::khtmlMouseMoveEvent( kht
     // selection stuff
     if( d->m_bMousePressed && innerNode.handle() && innerNode.handle()->renderer() &&
         ( _mouse->state() == LeftButton )) {
-      int offset;
+      int offset = 0;
       //kdDebug(6000) << "KHTMLPart::khtmlMouseMoveEvent x=" << event->x() << " y=" << event->y()
       //              << " nodeAbsX=" << event->nodeAbsX() << " nodeAbsY=" << event->nodeAbsY()
       //              << endl;

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]