[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Highlighting thumbnails in konqueror
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-12 17:36:55
[Download RAW message or body]

> One _VERY_ major question though: the original code calls setIcon() which in 
> turn calls m_fileitem->pixmap() for every state change. Is there a reason for 
> this, besides killing performance for re-discovering that the icon hasn't 
> been changed? Unless it is possible that active icons are different (that is, 
> not only the effect, but also the base image itself), it doesn't make sense 
> to call this code for highlighting. And now I already have a pixmap for 
> caching in place for the thumbs I might as well use it for the normal icons.

I was calling m_fileitem->pixmap( m_size, m_state ) because that was the only
way I knew for passing a new state and getting it applied to the icon
(I'm clueless about this effect stuff).
Your proposed change sounds good.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]