[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Highlighting thumbnails in konqueror
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-12 9:12:46
[Download RAW message or body]

On Thursday 12 July 2001 00:58, Martijn Klingens wrote:
> Until now thumbnail icons in Konq didn't use the icon highlighting settings. 
> For the default gamma effect that is not too annoying, but on LinuxTag I saw 
> the effect when 'colorize' is used instead on Rob Malda's notebook: that's 
> ugly!
> 
> Attached patch should enable highlighting for thumbs as well. To do this it 
> stores the thumb internally in the KFileIVI object, so the KIconEffects can 
> later be applied and undone again.
> 
> Carsten told me on #kde that libkonq will have to remain BC after 2.2, so I 
> added a d-pointer here instead of a local data member. This way we can at 
> least extend in the future ;-)
> 
> Please review. No objections == /me committing tomorrow.

Looks good, except for the code duplication.
Add a "reloadIcon" or whatever to KFileIVI, that takes care of
"if thumbnail then setThumbnailEffect else setIcon"
(in fact setThumbnailEffect isn't necessary anymore then, you can
move its code into that method)
This code is duplicated 3 times in your patch...
Thanks !

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]