[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Highlighting thumbnails in konqueror
From:       Frerich Raabe <frerichraabe () gmx ! de>
Date:       2001-07-12 1:28:32
[Download RAW message or body]

On Thursday, 12. July 2001 00:58, Martijn Klingens wrote:
> Please review. No objections == /me committing tomorrow.

I think 'class KFileIVI_Private' should become 'struct Private;' and moved 
into the 'KFileIVI' namespace, i.e.

class KFileIVI
{
  ..
  private:
    struct Private;
    Private *d;
};

This avoids namespace pollution.

- Frerich

[prev in list] [next in list] [prev in thread] [next in thread]