[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: HTTP ioslave port to TCPSlaveBase
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-07-11 17:59:19
[Download RAW message or body]

On Monday 02 July 2001 08:55 pm, Dawit Alemayehu wrote:
> Hi,
>
> Here is a link to a first run patch (rather large to post here) that
> attempts to port kio_http to use TCPSlaveBase:
>
> http://users.starpower.net/adawit/kde2/patches/httpport.tgz
>
> This patch fixes:

I had a look at your patch from Jul. 7. It looks mostly ok. 

It has a line which fails to compile:
    while( buf == ' ' ) buf++;                                                
Appearanly should be:
    while( *buf == ' ' ) buf++;                                               

I'm currently testing your patch and I encounter some problems with wrong 
hostnames being sent but I don't know if that's a problem of your patch or of 
something else.

Cheers,
Waldo
-- 
I don't suffer from insanity,
          I enjoy every minute of it.

[prev in list] [next in list] [prev in thread] [next in thread]