[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kaction.cpp
From:       Martijn Klingens <mklingens () yahoo ! com>
Date:       2001-05-30 22:17:31
[Download RAW message or body]

On Wednesday 30 May 2001 22:07, David Faure wrote:
> > Well.. If that code was committed recently, then my patch apparently
> > reverts it :) That was not the intention, though.
>
> Well, look at the patch.....

Seems like a misunderstanding here... I only call something 'reverting' if it 
means going back to a previous situation, not if it just changes (or turns 
of, like in this case) certain behaviour... But that's nit-picking and 
doesn't really matter...

> [ - snip ] -
>
> I'm not even sure what you are trying to fix here..... please review your
> patch and explain...

Look at kwin's context menu for a window's title bar for example, or to 
kicker's context menu for taskbar entries. Items like 'always on top' and 
'store settings' are essentially toggle actions, although they don't use 
KAction. And they also have an icon! This is done because the background of 
the icon is shown 'sunken' if the item is checked. And that is exactly what I 
wanted to achieve in KAction as well...

Sorry if that wasn't clear, I thought everyone knew that toggled entries in a 
menu could still have icons because they don't _need_ a checkmark, only if 
they don't have an icon. I hope this explains it a bit, because I don't think 
I can explain it any better :-/

Martijn

[prev in list] [next in list] [prev in thread] [next in thread]