[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] Re: Help please: I still get greyed out icons in kicker
From:       Michael Matz <matz () ifh ! de>
Date:       2000-09-29 17:21:33
[Download RAW message or body]

Hi,

On Fri, 29 Sep 2000, David Faure wrote:
> >I believe this is because the one who added the "Panel" icon group didn't
> >add that group to all places where needed (despite the fairly clear
> >comment in kicontheme.h). The attached patch fixes that.
> 
> +    groups += "Panel";
>      int defDefSizes[] = { 32, 22, 22, 16 };
> 
> Shouldn't there be a default size for the new group, as well ?

Yep, 32 I guess. For the normally needed changes in the two
kdelibs/pics/{lo,hi}color/index.desktop files I'm not too sure, because
the size of the panel icons is not changeable in the normal
kcontrol/L&F/Icons dialog, but changes according to the configured size of
the panel. Anyway I guess there it should be done too (second attachment).

> /me smiling at the fact that this group was there, then removed, then
> re-added :)

What's left? hmm... I know: this time we can rename it ;-)


Ciao,
Michael.

["kiconstuff.diff" (TEXT/PLAIN)]

Index: kicontheme.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kicontheme.cpp,v
retrieving revision 1.32
diff -u -r1.32 kicontheme.cpp
--- kicontheme.cpp	2000/09/28 21:55:22	1.32
+++ kicontheme.cpp	2000/09/29 17:19:24
@@ -165,7 +165,8 @@
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
-    int defDefSizes[] = { 32, 22, 22, 16 };
+    groups += "Panel";
+    int defDefSizes[] = { 32, 22, 22, 16, 32 };
     cfg.setGroup("KDE Icon Theme");
     for (it=groups.begin(), i=0; it!=groups.end(); it++, i++)
     {
Index: kiconeffect.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kiconeffect.cpp,v
retrieving revision 1.22
diff -u -r1.22 kiconeffect.cpp
--- kiconeffect.cpp	2000/09/12 02:09:32	1.22
+++ kiconeffect.cpp	2000/09/29 17:19:24
@@ -51,6 +51,7 @@
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
+    groups += "Panel";
 
     QStringList states;
     states += "Default";

["iconbla.diff" (TEXT/PLAIN)]

? iconbla.diff
Index: hicolor/index.desktop
===================================================================
RCS file: /home/kde/kdelibs/pics/hicolor/index.desktop,v
retrieving revision 1.59
diff -u -r1.59 index.desktop
--- hicolor/index.desktop	2000/09/28 05:25:46	1.59
+++ hicolor/index.desktop	2000/09/29 17:12:40
@@ -65,6 +65,8 @@
 ToolbarSizes=16,22,32
 MainToolbarDefault=22
 MainToolbarSizes=16,22,32
+PanelDefault=32
+PanelSizes=16,32,48
 SmallDefault=16
 SmallSizes=16
 Directories=22x22/actions,32x32/apps,32x32/devices,32x32/filesystems,32x32/mimetypes, \
32x32/actions,48x48/apps,48x48/devices,48x48/filesystems,48x48/mimetypes,scalable/apps,scalable/devices,scalable/filesystems,scalable/mimetypes
                
Index: locolor/index.desktop
===================================================================
RCS file: /home/kde/kdelibs/pics/locolor/index.desktop,v
retrieving revision 1.53
diff -u -r1.53 index.desktop
--- locolor/index.desktop	2000/09/28 05:25:49	1.53
+++ locolor/index.desktop	2000/09/29 17:12:40
@@ -62,6 +62,8 @@
 ToolbarSizes=16,22,32
 MainToolbarDefault=22
 MainToolbarSizes=16,22,32
+PanelDefault=32
+PanelSizes=16,32
 SmallDefault=16
 SmallSizes=16
 LockOverlay=lockoverlay



[prev in list] [next in list] [prev in thread] [next in thread]