[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] Re: Help please: I still get greyed out icons in kicker
From:       Thomas Leitner <tom () radar ! tu-graz ! ac ! at>
Date:       2000-09-29 18:38:18
[Download RAW message or body]

On Fri, 29 Sep 2000, Michael Matz wrote:

> > above method is called to grey out my kicker icons.
> 
> I believe this is because the one who added the "Panel" icon group didn't
> add that group to all places where needed (despite the fairly clear
> comment in kicontheme.h). The attached patch fixes that.

Jippie !! This works !! Good work Michael. I've needed to change one line
in kiconeffect.cpp to get it going with Compaq C++. In Line 142, the
"QColor col" parameter is lacking a "const" modifier because there's
a "const" in the class specification and Compaq C++ complains about that
difference.

So please could you commit these changes to the CVS!

I can report that apart from one small patch in koffice, KDE2 can now
fully be compiled with Compaq C++ under Tru64 and supposedly Linux/AXP
as well.

Good work.

Thanks // Tom
-- 
--------------------------------------------------------------------------
Dr. Tom Leitner                             Dept. of Communications
                                            Graz University of Technology, 
e-mail    : tom@radar.tu-graz.ac.at         Inffeldgasse 12
Phone     : +43-316-873-7455                A-8010 Graz / Austria / Europe
Fax       : +43-316-463-697
Home page : http://wiis.tu-graz.ac.at/people/tom.html
PGP public key on : ftp://wiis.tu-graz.ac.at/pgp-keys/tom.asc or send 
mail with subject "get Thomas Leitner" to pgp-public-keys@keys.pgp.net
--------------------------------------------------------------------------
    Before we have the paperless office, we have the paperless toilet!

["kicontheme_new.patch" (TEXT/PLAIN)]

Index: kiconeffect.cpp
===================================================================
RCS file: /home6/kde2/repository/kdelibs/kdecore/kiconeffect.cpp,v
retrieving revision 1.22
diff -u -p -r1.22 kiconeffect.cpp
--- kiconeffect.cpp	2000/09/12 02:09:32	1.22
+++ kiconeffect.cpp	2000/09/29 18:30:15
@@ -51,6 +51,7 @@ void KIconEffect::init()
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
+    groups += "Panel";
 
     QStringList states;
     states += "Default";
@@ -138,7 +139,7 @@ QImage KIconEffect::apply(QImage image, 
 	    mColor[group][state], mTrans[group][state]);
 }
 
-QImage KIconEffect::apply(QImage image, int effect, float value, QColor col, bool trans)
+QImage KIconEffect::apply(QImage image, int effect, float value, const QColor col, bool trans)
 {
     if (effect >= LastEffect )
     {
Index: kicontheme.cpp
===================================================================
RCS file: /home6/kde2/repository/kdelibs/kdecore/kicontheme.cpp,v
retrieving revision 1.32
diff -u -p -r1.32 kicontheme.cpp
--- kicontheme.cpp	2000/09/28 21:55:22	1.32
+++ kicontheme.cpp	2000/09/29 18:29:16
@@ -165,6 +165,7 @@ KIconTheme::KIconTheme(const QString& na
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
+    groups += "Panel";
     int defDefSizes[] = { 32, 22, 22, 16 };
     cfg.setGroup("KDE Icon Theme");
     for (it=groups.begin(), i=0; it!=groups.end(); it++, i++)


[prev in list] [next in list] [prev in thread] [next in thread]