[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [patch] Re: Help please: I still get greyed out icons in kicker
From:       Michael Matz <matzmich () cs ! tu-berlin ! de>
Date:       2000-09-29 16:37:45
[Download RAW message or body]

Hi Tom,

On Fri, 29 Sep 2000, Thomas Leitner wrote:
> Can anyone please try to help me with the greyed out icons problem in
> kicker. Here's an example of how this looks like:
> 
>           http://finwds01.tu-graz.ac.at/tmp/grey_icons.gif
> 
> I found out that the routine responsible for this is:
> 
>         void KIconEffect::semiTransparent(QImage &img)
> 
> I have the System++ style loaded and I can't figure out why the 
> above method is called to grey out my kicker icons.

I believe this is because the one who added the "Panel" icon group didn't
add that group to all places where needed (despite the fairly clear
comment in kicontheme.h). The attached patch fixes that.


Ciao,
Michael.

["kiconstuff.diff" (TEXT/PLAIN)]

Index: kiconeffect.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kiconeffect.cpp,v
retrieving revision 1.22
diff -u -r1.22 kiconeffect.cpp
--- kiconeffect.cpp	2000/09/12 02:09:32	1.22
+++ kiconeffect.cpp	2000/09/29 16:33:38
@@ -51,6 +51,7 @@
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
+    groups += "Panel";
 
     QStringList states;
     states += "Default";
Index: kicontheme.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kicontheme.cpp,v
retrieving revision 1.32
diff -u -r1.32 kicontheme.cpp
--- kicontheme.cpp	2000/09/28 21:55:22	1.32
+++ kicontheme.cpp	2000/09/29 16:33:38
@@ -165,6 +165,7 @@
     groups += "Toolbar";
     groups += "MainToolbar";
     groups += "Small";
+    groups += "Panel";
     int defDefSizes[] = { 32, 22, 22, 16 };
     cfg.setGroup("KDE Icon Theme");
     for (it=groups.begin(), i=0; it!=groups.end(); it++, i++)


[prev in list] [next in list] [prev in thread] [next in thread]