--===============7068322373887738685== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 ----------------------------------------------------------- startkde/kcminit/CMakeLists.txt you forgot to git add the config-xcb.h.cmake - Martin Gräßlin On Feb. 4, 2015, 1:31 a.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122320/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 1:31 a.m.) > > > Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. > > > Repository: plasma-workspace > > > Description > ------- > > this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). > > for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. > > switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. > > > Diffs > ----- > > startkde/kcminit/CMakeLists.txt b17951f > startkde/kcminit/main.cpp 1008966 > > Diff: https://git.reviewboard.kde.org/r/122320/diff/ > > > Testing > ------- > > i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. > > > Thanks, > > Nick Shaforostoff > > --===============7068322373887738685== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/

startkde/kcminit/CMakeLists.txt (Diff revision 4)
		6	configure_file(config-xcb.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-xcb.h)

you forgot to git add the config-xcb.h.cmake

- Martin Gräßlin

On February 4th, 2015, 1:31 a.m. CET, Nick Shaforostoff wrote:

Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.

By Nick Shaforostoff.

Updated Feb. 4, 2015, 1:31 a.m.

Repository: plasma-workspace

Description

this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count().

for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'.

switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication.

Testing

i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine.

Diffs

startkde/kcminit/CMakeLists.txt (b17951f)
startkde/kcminit/main.cpp (1008966)

--===============7068322373887738685==--