[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 122394: Fix OSX library names in kdeinit5.app
From:       "David Faure" <faure () kde ! org>
Date:       2015-02-03 6:46:42
Message-ID: 20150203064642.19249.93193 () probe ! kde ! org
[Download RAW message or body]

--===============2659451542139296199==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122394/#review75253
-----------------------------------------------------------

Ship it!


René, these are shared libs, not plugins, so their name is correct.

- David Faure


On fév. 2, 2015, 8:51 après-midi, Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122394/
> -----------------------------------------------------------
> 
> (Updated fév. 2, 2015, 8:51 après-midi)
> 
> 
> Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.
> 
> 
> Bugs: 343707
> https://bugs.kde.org/show_bug.cgi?id=343707
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the \
> correct libraries needed. 
> 
> Diffs
> -----
> 
> src/kdeinit/kinit.cpp 3c3c913 
> 
> Diff: https://git.reviewboard.kde.org/r/122394/diff/
> 
> 
> Testing
> -------
> 
> kdeinit5.app no longer complains about the missing .so libraries.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
> 


--===============2659451542139296199==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122394/">https://git.reviewboard.kde.org/r/122394/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">René, these are shared libs, not plugins, so their name is \
correct.</p></pre>  <br />









<p>- David Faure</p>


<br />
<p>On février 2nd, 2015, 8:51 après-midi UTC, Jeremy Whiting wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian \
Wadham.</div> <div>By Jeremy Whiting.</div>


<p style="color: grey;"><i>Updated fév. 2, 2015, 8:51 après-midi</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=343707">343707</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OSX Doesn't have .so libraries, so use OSX names in \
kdeinit5.app to load the correct libraries needed.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kdeinit5.app no longer complains about the missing .so \
libraries.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeinit/kinit.cpp <span style="color: grey">(3c3c913)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122394/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============2659451542139296199==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic