[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122394: Fix OSX library names in kdeinit5.app
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-02-02 23:44:31
Message-ID: 20150202234431.19248.75915 () probe ! kde ! org
[Download RAW message or body]
--===============1526502449262491542==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 2, 2015, 10:56 p.m., René J.V. Bertin wrote:
> > src/kdeinit/kinit.cpp, lines 90-92
> > <https://git.reviewboard.kde.org/r/122394/diff/1/?file=346478#file346478line90>
> >
> > These are true shared libraries that are also used for "-l" style linking with \
> > ld?
>
> Jeremy Whiting wrote:
> I'm not sure I understand the question, is there some other type of library on OSX \
> besides "true shared libraries that are also used for -l style linking with ld"? \
> file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that \
> helps answer your question.
What I mean is if there are applications (or other libraries) that link in those \
libraries using `-lKF5KIOCore`, `-lKF5Parts` or `-lKF5Plasma`. In that case, the \
.dylib extension is obligatory. In all other cases, the extension can in fact be \
anything. Thus, plugins and modules usually have the .so extension on OS X, just like \
on Linux.
Your modification is correct in itself (evidently, if you not longer get complaints \
about libraries not being found). But if those libraries are only ever loaded \
dynamically you could also modify the CMake file so that they are created with a .so \
extension (and leave the C++ code alone).
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122394/#review75242
-----------------------------------------------------------
On Feb. 2, 2015, 9:51 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122394/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 9:51 p.m.)
>
>
> Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.
>
>
> Bugs: 343707
> https://bugs.kde.org/show_bug.cgi?id=343707
>
>
> Repository: kinit
>
>
> Description
> -------
>
> OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the \
> correct libraries needed.
>
> Diffs
> -----
>
> src/kdeinit/kinit.cpp 3c3c913
>
> Diff: https://git.reviewboard.kde.org/r/122394/diff/
>
>
> Testing
> -------
>
> kdeinit5.app no longer complains about the missing .so libraries.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============1526502449262491542==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122394/">https://git.reviewboard.kde.org/r/122394/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 2nd, 2015, 10:56 p.m. CET, <b>René \
J.V. Bertin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122394/diff/1/?file=346478#file346478line90" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kdeinit/kinit.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">90</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"libKF5KIOCore.5.dylib"</span><span class="p">,</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">91</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"libKF5Parts.5.dylib"</span><span class="p">,</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"libKF5Plasma.5.dylib"</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These \
are true shared libraries that are also used for "-l" style linking with \
ld?</p></pre> </blockquote>
<p>On February 2nd, 2015, 11:17 p.m. CET, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not sure I understand the question, is there some other type of library on OSX \
besides "true shared libraries that are also used for -l style linking with ld"? file \
says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps \
answer your question.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What I mean is if there are applications (or other libraries) that link in \
those libraries using <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">-lKF5KIOCore</code>, <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">-lKF5Parts</code> or <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">-lKF5Plasma</code>. In that case, the .dylib extension is obligatory. In \
all other cases, the extension can in fact be anything. Thus, plugins and modules \
usually have the .so extension on OS X, just like on Linux.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Your \
modification is correct in itself (evidently, if you not longer get complaints about \
libraries not being found). But if those libraries are only ever loaded dynamically \
you could also modify the CMake file so that they are created with a .so extension \
(and leave the C++ code alone).</p></pre> <br />
<p>- René J.V.</p>
<br />
<p>On February 2nd, 2015, 9:51 p.m. CET, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian \
Wadham.</div> <div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2015, 9:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=343707">343707</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OSX Doesn't have .so libraries, so use OSX names in \
kdeinit5.app to load the correct libraries needed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kdeinit5.app no longer complains about the missing .so \
libraries.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdeinit/kinit.cpp <span style="color: grey">(3c3c913)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122394/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1526502449262491542==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic