From kde-core-devel Tue Feb 03 06:46:42 2015 From: "David Faure" Date: Tue, 03 Feb 2015 06:46:42 +0000 To: kde-core-devel Subject: Re: Review Request 122394: Fix OSX library names in kdeinit5.app Message-Id: <20150203064642.19249.93193 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=142294604801434 --===============2659451542139296199== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/#review75253 ----------------------------------------------------------- Ship it! René, these are shared libs, not plugins, so their name is correct. - David Faure On fév. 2, 2015, 8:51 après-midi, Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122394/ > ----------------------------------------------------------- > > (Updated fév. 2, 2015, 8:51 après-midi) > > > Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham. > > > Bugs: 343707 > https://bugs.kde.org/show_bug.cgi?id=343707 > > > Repository: kinit > > > Description > ------- > > OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed. > > > Diffs > ----- > > src/kdeinit/kinit.cpp 3c3c913 > > Diff: https://git.reviewboard.kde.org/r/122394/diff/ > > > Testing > ------- > > kdeinit5.app no longer complains about the missing .so libraries. > > > Thanks, > > Jeremy Whiting > > --===============2659451542139296199== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/

Ship it!

René, these are shared libs, not plugins, so their name is correct.


- David Faure


On février 2nd, 2015, 8:51 après-midi UTC, Jeremy Whiting wrote:

Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.
By Jeremy Whiting.

Updated fév. 2, 2015, 8:51 après-midi

Bugs: 343707
Repository: kinit

Description

OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

Testing

kdeinit5.app no longer complains about the missing .so libraries.

Diffs

  • src/kdeinit/kinit.cpp (3c3c913)

View Diff

--===============2659451542139296199==--