From kde-core-devel Mon Feb 02 23:44:31 2015 From: =?utf-8?b?UmVuw6kgSi5WLiBCZXJ0aW4=?= Date: Mon, 02 Feb 2015 23:44:31 +0000 To: kde-core-devel Subject: Re: Review Request 122394: Fix OSX library names in kdeinit5.app Message-Id: <20150202234431.19248.75915 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=142292071626464 --===============1526502449262491542== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Feb. 2, 2015, 10:56 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit.cpp, lines 90-92 > > > > > > These are true shared libraries that are also used for "-l" style linking with ld? > > Jeremy Whiting wrote: > I'm not sure I understand the question, is there some other type of library on OSX besides "true shared libraries that are also used for -l style linking with ld"? file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps answer your question. What I mean is if there are applications (or other libraries) that link in those libraries using `-lKF5KIOCore`, `-lKF5Parts` or `-lKF5Plasma`. In that case, the .dylib extension is obligatory. In all other cases, the extension can in fact be anything. Thus, plugins and modules usually have the .so extension on OS X, just like on Linux. Your modification is correct in itself (evidently, if you not longer get complaints about libraries not being found). But if those libraries are only ever loaded dynamically you could also modify the CMake file so that they are created with a .so extension (and leave the C++ code alone). - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/#review75242 ----------------------------------------------------------- On Feb. 2, 2015, 9:51 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122394/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 9:51 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham. > > > Bugs: 343707 > https://bugs.kde.org/show_bug.cgi?id=343707 > > > Repository: kinit > > > Description > ------- > > OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed. > > > Diffs > ----- > > src/kdeinit/kinit.cpp 3c3c913 > > Diff: https://git.reviewboard.kde.org/r/122394/diff/ > > > Testing > ------- > > kdeinit5.app no longer complains about the missing .so libraries. > > > Thanks, > > Jeremy Whiting > > --===============1526502449262491542== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122394/

On February 2nd, 2015, 10:56 p.m. CET, René J.V. Bertin wrote:

src/kdeinit/kinit.cpp (Diff revision 1) 

    90
    
    "libKF5KIOCore.5.dylib",

  


  

    
    

    91
    
    "libKF5Parts.5.dylib",

  


  

    
    

    92
    
    "libKF5Plasma.5.dylib"

  


 




  
These are true shared libraries that are also used for "-l" style linking with ld?

 




 
On February 2nd, 2015, 11:17 p.m. CET, Jeremy Whiting wrote:

 

  
I'm not sure I understand the question, is there some other type of library on OSX besides "true shared libraries that are also used for -l style linking with ld"? file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps answer your question.

 











What I mean is if there are applications (or other libraries) that link in those libraries using -lKF5KIOCore, -lKF5Parts or -lKF5Plasma. In that case, the .dylib extension is obligatory. In all other cases, the extension can in fact be anything. Thus, plugins and modules usually have the .so extension on OS X, just like on Linux.


Your modification is correct in itself (evidently, if you not longer get complaints about libraries not being found). But if those libraries are only ever loaded dynamically you could also modify the CMake file so that they are created with a .so extension (and leave the C++ code alone).








- René J.V.






On February 2nd, 2015, 9:51 p.m. CET, Jeremy Whiting wrote:












 

  


Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.


By Jeremy Whiting.




Updated Feb. 2, 2015, 9:51 p.m.










 Bugs: 


 343707









 Repository: 
kinit





Description 

 

 

  
   
OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

  		
 






Testing 



 

  
   
kdeinit5.app no longer complains about the missing .so libraries.

  		
 






Diffs 


    

 
  • src/kdeinit/kinit.cpp (3c3c913)
    • 





View Diff







  		
 











  

 



--===============1526502449262491542==--