--nextPart2936113.ofFVT7DxUZ
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Sun, November 10, 2013 11:18:19 Wolfgang Bauer wrote:
> > -----Original Message-----
> > From: Rolf Eike Beer [mailto:kde@opensource.sf-tec.de]
> > Sent: Sunday, November 10, 2013 9:11 AM
> > To: kde-core-devel@kde.org; Wolfgang Bauer
> > Cc: David Stephen Hubner
> > Subject: Re: Review Request 113779: KInfocenter/OpenGL: fix
> > ReadPipe() in the case that the command cannot be run
> > 
> > 
> > Can't this be ported to simply use QProcess instead?
> > 
> > Eike
> 
> Well, I only wanted to fix this bug... ;-)
> But I can have a look at reimplementing this with QProcess as well.
> 
> How should I proceed?
> Commit this for now to fix the bug (maybe to the 4.11 branch only)?
> Or discard this patch and just rewrite ReadPipe() using QProcess?

I would recommend applying the patch to 4.11 and master and then investigating 
whether QProcess would be suitable for master (this might also help with KF5 
and Windows porting, not that I expect KInfoCenter to do great things on 
Windows).

Regards,
 - Michael Pyne
--nextPart2936113.ofFVT7DxUZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAABCAAGBQJSf6b9AAoJEAuvDJx7aunyEowQAIg0n97Q8pkKiS+o3rr4iTFY
oJAWfzNpWxRqd49qHaeVJR7+jtW9t4O/hrpeAAwAFrcnSU9Vc8r4qvbOPk9FLomr
TGgHtBk12VDS4LBBOlgRu1aO1aaT4O9EVehyNVRZO8moUJp4RmfFaOdZNnDf5Dvr
q+VWYgnMH6nQDVkhdjx0WZAzz0aJVRbp3tzaj4knlW4kroYqi/BmfFLki1lJ6RTG
nP7YZNOaF2XHwP2COJ7ovC7Y1VjxLZyfoWKQgykdqLHG5RWAUz1SjT/StF4zLxks
JJeFCCUp9choL8g/PU1FrjqlwN0Iz6Dxs5A2l9jcAEQfanwE6fsa7lVYqQ+/l91g
qfgcdS09vRO9AO+hp+0H+yLUzVFTaGEUBBwbWe4D60YPhlo2jZHp95socBO5QMwq
A7lKL75N1gehNQiasy+z+4hZ3wdF8XG/VzWb3yngm9ieoeTVVD1nU85CXXuGqJ4s
bJquOtzP1uq/YU6WW2qMKypSp6S+gF4f02ObT2DfmcWGe1Kf2NUhb/uLS94psoY9
5PGTZ2BuM69A0zXeaq9fzA2R/TWh5i2aROh1VvvB/fduqSlM1aDyFFlG4FazQMcN
EAFLPVqDP61aeC0Y2/lcxQ8466FecNOWuobyyjE6XCtUvDZDymZ4W7ifXmtv+ANK
V3LehRYfNG+0U9LjffCl
=52be
-----END PGP SIGNATURE-----

--nextPart2936113.ofFVT7DxUZ--