[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
From: "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date: 2013-10-17 13:40:38
Message-ID: 20131017134038.2860.14380 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112991/#review41886
-----------------------------------------------------------
The patch doesn't apply cleanly to KDE/4.11 branch - it looks reasonable to me. If \
you correct that patch I can double-check it builds here.
- Kurt Hindenburg
On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112991/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2013, 5:15 p.m.)
>
>
> Review request for kde-workspace.
>
>
> Bugs: https://trac.macports.org/ticket/33780
> http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> This patch fix broken compilation under OSX / macports about kde-workspace.
>
> Patch do not touch implementation. Only compilation rules are changed in cmake \
> script to follow the way way than Windows rules, where no X11 lib are available.
> By this way, Oxygen is compiled and installed to macport and digiKam has a suitable \
> GUI under OSX.
> See my Macports bug report for details : https://trac.macports.org/ticket/33780
>
> Gilles Caulier
>
>
> Diffs
> -----
>
> CMakeLists.txt c37ab8b
> kcontrol/CMakeLists.txt a25aaa0
> libs/CMakeLists.txt 9d71a03
>
> Diff: http://git.reviewboard.kde.org/r/112991/diff/
>
>
> Testing
> -------
>
> I tested this patch under my macbook pro, using a fresh install of Macports (KDE \
> 4.11.1 / Qt 4.8.5)
> As kde-workspace macports package is broken, i checkout code from KDE git/master \
> repository and fixed compilation rules as well.
>
> Thanks,
>
> Gilles Caulier
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112991/">http://git.reviewboard.kde.org/r/112991/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch doesn't \
apply cleanly to KDE/4.11 branch - it looks reasonable to me. If you correct that \
patch I can double-check it builds here.</pre> <br />
<p>- Kurt Hindenburg</p>
<br />
<p>On September 29th, 2013, 5:15 p.m. UTC, Gilles Caulier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Gilles Caulier.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2013, 5:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780">https://trac.macports.org/ticket/33780</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fix broken compilation under OSX / macports about \
kde-workspace.
Patch do not touch implementation. Only compilation rules are changed in cmake script \
to follow the way way than Windows rules, where no X11 lib are available.
By this way, Oxygen is compiled and installed to macport and digiKam has a suitable \
GUI under OSX.
See my Macports bug report for details : https://trac.macports.org/ticket/33780
Gilles Caulier</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested this patch under my macbook pro, using a fresh install of \
Macports (KDE 4.11.1 / Qt 4.8.5)
As kde-workspace macports package is broken, i checkout code from KDE git/master \
repository and fixed compilation rules as well. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c37ab8b)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(a25aaa0)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(9d71a03)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112991/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic