[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113298: KDirWatch code style: cleanup whitespace.
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2013-10-17 7:46:35
Message-ID: 20131017074635.29676.6912 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/#review41860
-----------------------------------------------------------
There are couple issues still, I pointed only bunch of them as they repeat \
themselves, so you might want to keep an eye on those
Also, kdelibs coding style - http://techbase.kde.org/Policies/Kdelibs_Coding_Style
tier1/kcoreaddons/src/lib/io/kdirwatch.h
<http://git.reviewboard.kde.org/r/113298/#comment30546>
As per the kdelibs coding style, there should be spaces around operators too, so \
eg. "notify = false" etc
tier1/kcoreaddons/src/lib/io/kdirwatch.h
<http://git.reviewboard.kde.org/r/113298/#comment30547>
The & sign should be aligned at the variable name, eg. "QString &path" (like you \
have below)
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30548>
Entry* e -> Entry *e
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30549>
There should be no spaces before ";", eg. "...!= end; ++it"
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30550>
Indent on 4 spaces
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30551>
Operator spaces:
if (res < 0) {
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30552>
Operator spaces as well
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30553>
This should probably be on separate lines
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30554>
Same as the block above
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30555>
Entry *e
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30556>
Indent one level more (should be 8 spaces at this level)....actually this whole \
file seems to have wrong indentation, so maybe fix all of that?
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30557>
Pointer signs to the variable -> KDirWatch *instance etc
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp
<http://git.reviewboard.kde.org/r/113298/#comment30558>
Should be at the "if" line, eg. "if () {"
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h
<http://git.reviewboard.kde.org/r/113298/#comment30559>
Spaces inside -> "KDirWatch *, bool"
- Martin Klapetek
On Oct. 17, 2013, 3:51 a.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113298/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 3:51 a.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KDirWatch code style: cleanup whitespace.
>
> The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
> alignment, including a few tabs(!). This is a full cleanup of it.
> I appreciate any feedback; if I "fixed" something that didn't need fixing, or if \
> you see more whitespace errors that I didn't fix, or if I should push this to \
> master too, or if I should leave the damn thing alone and discard the review :)
> This file is also lacking braces for single-line conditionals and loops; I'll fix \
> that in a separate commit for easier reviewing. It's also mixing 2-space and \
> 4-space indentations, but changing everything to 4 spaces (as the kdelibs coding \
> style says) seemed too intrusive. Perhaps I should change the few 4-space \
> indentations into 2-space for consistency?
>
> Diffs
> -----
>
> tier1/kcoreaddons/src/lib/io/kdirwatch.h 7f6ca8ce83426c81a6336514c247aa9d115ec59e
> tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a \
> tier1/kcoreaddons/src/lib/io/kdirwatch_p.h \
> 442d6497b704c179adc13dbb25e450554d31554d
> Diff: http://git.reviewboard.kde.org/r/113298/diff/
>
>
> Testing
> -------
>
> Still compiles :)
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113298/">http://git.reviewboard.kde.org/r/113298/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are couple issues \
still, I pointed only bunch of them as they repeat themselves, so you might want to \
keep an eye on those
Also, kdelibs coding style - \
http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202293#file202293line192" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KCOREADDONS_EXPORT KDirWatch : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">192</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">startScan</span><span class="p">(</span> \
<span class="kt">bool</span> <span class="n">notify</span><span \
class="o">=</span><span class="nb">false</span><span class="p">,</span> <span \
class="kt">bool</span> <span class="n">skippedToo</span><span class="o">=</span><span \
class="nb">false</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">192</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">startScan</span><span class="p">(</span><span \
class="kt">bool</span> <span class="n">notify</span><span class="o">=</span><span \
class="nb">false</span><span class="p">,</span> <span class="kt">bool</span> <span \
class="n">skippedToo</span><span class="o">=</span><span class="nb">false</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As per the \
kdelibs coding style, there should be spaces around operators too, so eg. \
"notify = false" etc</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202293#file202293line213" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KCOREADDONS_EXPORT KDirWatch : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">213</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">contains</span><span class="p">(</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">path</span> <span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">213</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">contains</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">path</span><span class="p">)</span> <span class="k">const</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The & \
sign should be aligned at the variable name, eg. "QString &path" (like \
you have below)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line339" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KDirWatchPrivate::~KDirWatchPrivate()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">339</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="n">e</span> <span \
class="o">=</span> <span class="o">&</span><span class="p">(</span> <span \
class="o">*</span><span class="n">it</span> <span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">339</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="n">e</span> <span \
class="o">=</span> <span class="o">&</span><span class="p">(</span><span \
class="o">*</span><span class="n">it</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Entry* e \
-> Entry *e</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line515" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDirWatchPrivate::Entry::addClient(KDirWatch* instance,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">515</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> \
<span class="p">(</span> <span class="p">;</span> <span class="n">it</span> <span \
class="o">!=</span> <span class="n">end</span> <span class="p">;</span> <span \
class="o">++</span><span class="n">it</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">515</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span \
class="p">(</span> <span class="p">;</span> <span class="n">it</span> <span \
class="o">!=</span> <span class="n">end</span> <span class="p">;</span> <span \
class="o">++</span><span class="n">it</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There \
should be no spaces before ";", eg. "...!= end; ++it"</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line614" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KDirWatchPrivate::Entry* KDirWatchPrivate::entry(const QString& \
_path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">614</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">path</span><span class="p">.</span><span class="n">truncate</span><span \
class="p">(</span> <span class="n">path</span><span class="p">.</span><span \
class="n">length</span><span class="p">()</span> <span class="o">-</span> <span \
class="mi">1</span> <span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">614</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">path</span><span class="p">.</span><span class="n">truncate</span><span \
class="p">(</span><span class="n">path</span><span class="p">.</span><span \
class="n">length</span><span class="p">()</span> <span class="o">-</span> <span \
class="mi">1</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indent on 4 \
spaces</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line658" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">658</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">res</span><span \
class="o"><</span><span class="mi">0</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">658</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">res</span><span class="o"><</span><span \
class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Operator \
spaces:
if (res < 0) {</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line660" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">660</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">use_fam</span><span class="o">=</span><span class="nb">false</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">660</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">use_fam</span><span \
class="o">=</span><span class="nb">false</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Operator \
spaces as well</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line661" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">661</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">delete</span> <span class="n">sn</span><span class="p">;</span> <span \
class="n">sn</span> <span class="o">=</span> <span class="mi">0</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">661</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span \
class="n">sn</span><span class="p">;</span> <span class="n">sn</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
probably be on separate lines</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line676" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">676</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">res</span><span \
class="o"><</span><span class="mi">0</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">676</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">res</span><span class="o"><</span><span \
class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">677</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">e</span><span class="o">-></span><span class="n">m_mode</span> <span \
class="o">=</span> <span class="n">UnknownMode</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">677</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">e</span><span \
class="o">-></span><span class="n">m_mode</span> <span class="o">=</span> <span \
class="n">UnknownMode</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">678</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">use_fam</span><span class="o">=</span><span class="nb">false</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">678</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">use_fam</span><span \
class="o">=</span><span class="nb">false</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">679</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">delete</span> <span class="n">sn</span><span class="p">;</span> <span \
class="n">sn</span> <span class="o">=</span> <span class="mi">0</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">679</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span \
class="n">sn</span><span class="p">;</span> <span class="n">sn</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same as the \
block above</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line698" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">698</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> \
<span class="n">KDirWatchPrivate</span><span class="o">::</span><span \
class="n">useINotify</span><span class="p">(</span> <span class="n">Entry</span><span \
class="o">*</span> <span class="n">e</span> <span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">698</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">KDirWatchPrivate</span><span \
class="o">::</span><span class="n">useINotify</span><span class="p">(</span><span \
class="n">Entry</span><span class="o">*</span> <span class="n">e</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Entry \
*e</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line720" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useFAM(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">720</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">s_verboseDebug</span><span class="p">)</span> \
<span class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">720</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">s_verboseDebug</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indent one \
level more (should be 8 spaces at this level)....actually this whole file seems to \
have wrong indentation, so maybe fix all of that?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line781" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useQFSWatch(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">781</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">KDirWatchPrivate</span><span class="o">::</span><span \
class="n">addEntry</span><span class="p">(</span><span \
class="n">KDirWatch</span><span class="o">*</span> <span \
class="n">instance</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">_path</span><span class="p">,</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">781</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">KDirWatchPrivate</span><span class="o">::</span><span \
class="n">addEntry</span><span class="p">(</span><span \
class="n">KDirWatch</span><span class="o">*</span> <span \
class="n">instance</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">_path</span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">782</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="n">sub_entry</span><span \
class="p">,</span> <span class="kt">bool</span> <span class="n">isDir</span><span \
class="p">,</span> <span class="n">KDirWatch</span><span class="o">::</span><span \
class="n">WatchModes</span> <span class="n">watchModes</span><span \
class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">782</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">Entry</span><span class="o">*</span> <span class="n">sub_entry</span><span \
class="p">,</span> <span class="kt">bool</span> <span class="n">isDir</span><span \
class="p">,</span> <span class="n">KDirWatch</span><span class="o">::</span><span \
class="n">WatchModes</span> <span class="n">watchModes</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pointer \
signs to the variable -> KDirWatch *instance etc</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line798" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KDirWatchPrivate::useQFSWatch(Entry* e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">798</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">798</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be \
at the "if" line, eg. "if () {"</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113298/diff/1/?file=202295#file202295line183" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kcoreaddons/src/lib/io/kdirwatch_p.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">183</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> \
<span class="nf">resetList</span> <span class="p">(</span><span \
class="n">KDirWatch</span><span class="o">*</span><span class="p">,</span><span \
class="kt">bool</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">183</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> \
<span class="nf">resetList</span><span class="p">(</span><span \
class="n">KDirWatch</span><span class="o">*</span><span class="p">,</span><span \
class="kt">bool</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Spaces \
inside -> "KDirWatch *, bool"</pre> </div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On October 17th, 2013, 3:51 a.m. UTC, Nicolás Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2013, 3:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDirWatch code style: cleanup whitespace.
The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
alignment, including a few tabs(!). This is a full cleanup of it.
I appreciate any feedback; if I "fixed" something that didn't need \
fixing, or if you see more whitespace errors that I didn't fix, or if I should \
push this to master too, or if I should leave the damn thing alone and discard the \
review :)
This file is also lacking braces for single-line conditionals and loops; I'll fix \
that in a separate commit for easier reviewing. It's also mixing 2-space and \
4-space indentations, but changing everything to 4 spaces (as the kdelibs coding \
style says) seemed too intrusive. Perhaps I should change the few 4-space \
indentations into 2-space for consistency?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still compiles :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.h <span style="color: \
grey">(7f6ca8ce83426c81a6336514c247aa9d115ec59e)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: \
grey">(e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <span style="color: \
grey">(442d6497b704c179adc13dbb25e450554d31554d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic