This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ 

The patch doesn't apply cleanly to KDE/4.11 branch - it looks reasonable to me.  If you correct that patch I can double-check it builds here.

- Kurt Hindenburg


On September 29th, 2013, 5:15 p.m. UTC, Gilles Caulier wrote:

Review request for kde-workspace.
By Gilles Caulier.

Updated Sept. 29, 2013, 5:15 p.m.

Repository: kde-workspace

Description 

This patch fix broken compilation under OSX / macports about kde-workspace.

Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available.

By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX.

See my Macports bug report for details : https://trac.macports.org/ticket/33780 

Gilles Caulier

Testing 

I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5)

As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well.

Diffs

  • CMakeLists.txt (c37ab8b)
  • kcontrol/CMakeLists.txt (a25aaa0)
  • libs/CMakeLists.txt (9d71a03)

View Diff