[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113216: some little performance improvement for network kio
From: Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date: 2013-10-12 22:41:22
Message-ID: 20131012224122.6878.54820 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113216/#review41617
-----------------------------------------------------------
This will not improve performance noticeably; QString is copy-on-write.
- Nicolás Alvarez
On Oct. 12, 2013, 9:06 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113216/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 9:06 a.m.)
>
>
> Review request for KDE Runtime.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> A new check by cppcheck (avoid to call the copy constructor).
> networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() \
> return const QString&.
>
> Diffs
> -----
>
> kioslave/network/ioslave/networkslave.cpp a548f1a
>
> Diff: http://git.reviewboard.kde.org/r/113216/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113216/">http://git.reviewboard.kde.org/r/113216/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will not improve \
performance noticeably; QString is copy-on-write.</pre> <br />
<p>- Nicolás Alvarez</p>
<br />
<p>On October 12th, 2013, 9:06 a.m. ART, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2013, 9:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A new check by cppcheck (avoid to call the copy constructor). \
networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() \
return const QString&.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/network/ioslave/networkslave.cpp <span style="color: \
grey">(a548f1a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic