From kde-core-devel Sat Oct 12 22:41:22 2013 From: =?utf-8?q?Nicol=C3=A1s_Alvarez?= Date: Sat, 12 Oct 2013 22:41:22 +0000 To: kde-core-devel Subject: Re: Review Request 113216: some little performance improvement for network kio Message-Id: <20131012224122.6878.54820 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138161771015679 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1399822600339705481==" --===============1399822600339705481== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/#review41617 ----------------------------------------------------------- This will not improve performance noticeably; QString is copy-on-write. - Nicolás Alvarez On Oct. 12, 2013, 9:06 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113216/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2013, 9:06 a.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > ------- > > A new check by cppcheck (avoid to call the copy constructor). > networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() return const QString&. > > > Diffs > ----- > > kioslave/network/ioslave/networkslave.cpp a548f1a > > Diff: http://git.reviewboard.kde.org/r/113216/diff/ > > > Testing > ------- > > > Thanks, > > Jaime Torres Amate > > --===============1399822600339705481== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/

This will not improve performance noticeably; QString is copy-on-write.

- Nicolás Alvarez

On October 12th, 2013, 9:06 a.m. ART, Jaime Torres Amate wrote:

Review request for KDE Runtime.

By Jaime Torres Amate.

Updated Oct. 12, 2013, 9:06 a.m.

Repository: kde-runtime

Description

A new check by cppcheck (avoid to call the copy constructor).
networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() return const QString&.

Diffs

kioslave/network/ioslave/networkslave.cpp (a548f1a)

View Diff

--===============1399822600339705481==--