This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/ 

This will not improve performance noticeably; QString is copy-on-write.

- Nicolás Alvarez


On October 12th, 2013, 9:06 a.m. ART, Jaime Torres Amate wrote:

Review request for KDE Runtime.
By Jaime Torres Amate.

Updated Oct. 12, 2013, 9:06 a.m.

Repository: kde-runtime

Description 

A new check by cppcheck (avoid to call the copy constructor).
networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() return const QString&.

Diffs

  • kioslave/network/ioslave/networkslave.cpp (a548f1a)

View Diff