[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerab
From: "Maks Orlovich" <maksim () kde ! org>
Date: 2012-07-06 13:31:08
Message-ID: 20120706133108.22736.99893 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/#review15457
-----------------------------------------------------------
Ship it!
Ship It!
- Maks Orlovich
On June 18, 2012, 10:23 p.m., Bernd Buschinski wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105122/
> -----------------------------------------------------------
> =
> (Updated June 18, 2012, 10:23 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[E=
numerable]]: false, [[Configurable]]: false
> ECMA Edition 5.1r6 - 15.3.5.2
> =
> the prototype must have DontEnum property otherwise it shows up as enumer=
able key.
> =
> =
> I expected that this must be fixed in the function_object.cpp constructor=
, but its never used in for code like
> =
> function foo() {};
> =
> =
> Diffs
> -----
> =
> kjs/bytecode/codes.def ae0a59f =
> kjs/function_object.cpp 4000212 =
> kjs/nodes.cpp 0b0749a =
> =
> Diff: http://git.reviewboard.kde.org/r/105122/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Bernd Buschinski
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105122/">http://git.reviewboard.kde.org/r/105122/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Maks</p>
<br />
<p>On June 18th, 2012, 10:23 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated June 18, 2012, 10:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: FunctionObject prototype attribute should be [[Writable]]: true, \
[[Enumerable]]: false, [[Configurable]]: false ECMA Edition 5.1r6 - 15.3.5.2
the prototype must have DontEnum property otherwise it shows up as enumerable key.
I expected that this must be fixed in the function_object.cpp constructor, but its \
never used in for code like
function foo() {};</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/bytecode/codes.def <span style="color: grey">(ae0a59f)</span></li>
<li>kjs/function_object.cpp <span style="color: grey">(4000212)</span></li>
<li>kjs/nodes.cpp <span style="color: grey">(0b0749a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105122/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic