From kde-core-devel Fri Jul 06 13:31:08 2012 From: "Maks Orlovich" Date: Fri, 06 Jul 2012 13:31:08 +0000 To: kde-core-devel Subject: Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerab Message-Id: <20120706133108.22736.99893 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134158172503272 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7333784676437180539==" --===============7333784676437180539== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105122/#review15457 ----------------------------------------------------------- Ship it! Ship It! - Maks Orlovich On June 18, 2012, 10:23 p.m., Bernd Buschinski wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105122/ > ----------------------------------------------------------- > = > (Updated June 18, 2012, 10:23 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[E= numerable]]: false, [[Configurable]]: false > ECMA Edition 5.1r6 - 15.3.5.2 > = > the prototype must have DontEnum property otherwise it shows up as enumer= able key. > = > = > I expected that this must be fixed in the function_object.cpp constructor= , but its never used in for code like > = > function foo() {}; > = > = > Diffs > ----- > = > kjs/bytecode/codes.def ae0a59f = > kjs/function_object.cpp 4000212 = > kjs/nodes.cpp 0b0749a = > = > Diff: http://git.reviewboard.kde.org/r/105122/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Bernd Buschinski > = > --===============7333784676437180539== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105122/

Ship it!

Ship It!
 









- Maks






On June 18th, 2012, 10:23 p.m., Bernd Buschinski wrote:









 

  


Review request for kdelibs.


By Bernd Buschinski.




Updated June 18, 2012, 10:23 p.m.








Descripti=
on 

 

 

  
   
kjs: FunctionObject prototype attribute should be [[Writable=
]]: true, [[Enumerable]]: false, [[Configurable]]: false
ECMA Edition 5.1r6 - 15.3.5.2

the prototype must have DontEnum property otherwise it shows up as enumerab=
le key.


I expected that this must be fixed in the function_object.cpp constructor, =
but its never used in for code like

function foo() {};

  		
 









Diffs=
 


    

 
  • kjs/bytecode/codes.def (ae0a59f)

 
  • kjs/function_object.cpp (4000212)

 
  • kjs/nodes.cpp (0b0749a)
    • 





View Diff
--===============7333784676437180539==--