This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105122/

Ship it!

Ship It!

- Maks


On June 18th, 2012, 10:23 p.m., Bernd Buschinski wrote:

Review request for kdelibs.
By Bernd Buschinski.

Updated June 18, 2012, 10:23 p.m.

Description

kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false
ECMA Edition 5.1r6 - 15.3.5.2

the prototype must have DontEnum property otherwise it shows up as enumerable key.


I expected that this must be fixed in the function_object.cpp constructor, but its never used in for code like

function foo() {};

Diffs

  • kjs/bytecode/codes.def (ae0a59f)
  • kjs/function_object.cpp (4000212)
  • kjs/nodes.cpp (0b0749a)

View Diff