[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kjs: Implement JSON.parse
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2012-07-05 6:49:05
Message-ID: 20120705064905.702.19132 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review15397
-----------------------------------------------------------
No functional review, just reading through the code.
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11995>
If "we" are in parse...?
kjs/jsonlexer.cpp
<http://git.reviewboard.kde.org/r/105056/#comment11996>
Can those 3 just be merged and use "return UChar(cur.uc);"?
- Rolf Eike Beer
On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
> =
> (Updated July 4, 2012, 10:27 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> kjs: Implement JSON.parse
> =
> =
> Diffs
> -----
> =
> kjs/CMakeLists.txt 1188064 =
> kjs/interpreter.cpp cf1acf1 =
> kjs/json_object.h PRE-CREATION =
> kjs/json_object.cpp PRE-CREATION =
> kjs/jsonlexer.h PRE-CREATION =
> kjs/jsonlexer.cpp PRE-CREATION =
> kjs/libkjs.map e9f679f =
> =
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Bernd Buschinski
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105056/">http://git.reviewboard.kde.org/r/105056/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">No functional review, just reading through the code.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/5/?file=71351#file71351line198" style="color: black; \
font-weight: bold; text-decoration: underline;">kjs/jsonlexer.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">JSValue* \
JSONParser::parse(ExecState* exec, ParserState state)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// If are in \
parse with type=JSONArray and state=TokLBrace,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">If "we" are in parse...?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/5/?file=71351#file71351line488" style="color: black; \
font-weight: bold; text-decoration: underline;">kjs/jsonlexer.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">JSValue* \
JSONParser::parse(ExecState* exec, ParserState state)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">488</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">case</span> <span \
class="sc">'b'</span><span class="o">:</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Can those 3 just be merged and use "return \
UChar(cur.uc);"?</pre> </div>
<br />
<p>- Rolf Eike</p>
<br />
<p>On July 4th, 2012, 10:27 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated July 4, 2012, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kjs: Implement JSON.parse</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/CMakeLists.txt <span style="color: grey">(1188064)</span></li>
<li>kjs/interpreter.cpp <span style="color: grey">(cf1acf1)</span></li>
<li>kjs/json_object.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/json_object.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/jsonlexer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/jsonlexer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/libkjs.map <span style="color: grey">(e9f679f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105056/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic