From kde-core-devel Thu Jul 05 06:49:05 2012 From: "Rolf Eike Beer" Date: Thu, 05 Jul 2012 06:49:05 +0000 To: kde-core-devel Subject: Re: Review Request: kjs: Implement JSON.parse Message-Id: <20120705064905.702.19132 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134147120328747 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4659379103735914005==" --===============4659379103735914005== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15397 ----------------------------------------------------------- No functional review, just reading through the code. kjs/jsonlexer.cpp If "we" are in parse...? kjs/jsonlexer.cpp Can those 3 just be merged and use "return UChar(cur.uc);"? - Rolf Eike Beer On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105056/ > ----------------------------------------------------------- > = > (Updated July 4, 2012, 10:27 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > kjs: Implement JSON.parse > = > = > Diffs > ----- > = > kjs/CMakeLists.txt 1188064 = > kjs/interpreter.cpp cf1acf1 = > kjs/json_object.h PRE-CREATION = > kjs/json_object.cpp PRE-CREATION = > kjs/jsonlexer.h PRE-CREATION = > kjs/jsonlexer.cpp PRE-CREATION = > kjs/libkjs.map e9f679f = > = > Diff: http://git.reviewboard.kde.org/r/105056/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Bernd Buschinski > = > --===============4659379103735914005== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105056/

No functio=
nal review, just reading through the code.

= =

kjs/jsonlexer.cpp (Diff revision 5)
	JSValue* JSONParser::parse(ExecState* exec, ParserState state)
		198	// If are i= n parse with type=3DJSONArray and state=3DTokLBrace,

If "we" are in parse...?

= =

kjs/jsonlexer.cpp (Diff revision 5)
	JSValue* JSONParser::parse(ExecState* exec, ParserState state)
		488	case 'b':

Can those 3 just be merged and use "return UChar(cur.uc);"=
?

- Rolf Eike

On July 4th, 2012, 10:27 p.m., Bernd Buschinski wrote:

Review request for kdelibs.

By Bernd Buschinski.

Updated July 4, 2012, 10:27 p.m.

Descripti= on

kjs: Implement JSON.parse

Diffs=

kjs/CMakeLists.txt (1188064)
kjs/interpreter.cpp (cf1acf1)
kjs/json_object.h (PRE-CREATION)
kjs/json_object.cpp (PRE-CREATION)<= /li>
kjs/jsonlexer.h (PRE-CREATION)
kjs/jsonlexer.cpp (PRE-CREATION)
kjs/libkjs.map (e9f679f)

--===============4659379103735914005==--