This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/

No functional review, just reading through the code.

kjs/jsonlexer.cpp (Diff revision 5)
JSValue* JSONParser::parse(ExecState* exec, ParserState state)
198
                // If are in parse with type=JSONArray and state=TokLBrace,
If "we" are in parse...?

kjs/jsonlexer.cpp (Diff revision 5)
JSValue* JSONParser::parse(ExecState* exec, ParserState state)
488
        case 'b':
Can those 3 just be merged and use "return UChar(cur.uc);"?

- Rolf Eike


On July 4th, 2012, 10:27 p.m., Bernd Buschinski wrote:

Review request for kdelibs.
By Bernd Buschinski.

Updated July 4, 2012, 10:27 p.m.

Description

kjs: Implement JSON.parse

Diffs

  • kjs/CMakeLists.txt (1188064)
  • kjs/interpreter.cpp (cf1acf1)
  • kjs/json_object.h (PRE-CREATION)
  • kjs/json_object.cpp (PRE-CREATION)
  • kjs/jsonlexer.h (PRE-CREATION)
  • kjs/jsonlexer.cpp (PRE-CREATION)
  • kjs/libkjs.map (e9f679f)

View Diff