[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Make the tab group Xproperty accessable via
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-10 10:25:11
Message-ID: 20111110102511.21467.87081 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 10, 2011, 10:02 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > I would like to see this in kdelibs 4.8. It is a rather minor change an=
d should be fine for 4.7 as well. But I don't know what's the state for add=
itions to kdelibs currently...
> =
> Christoph Feck wrote:
> The freeze is today, which means it has to go in today.
this is a new feature. it is not needed to address any functionality bugs. =
so it belongs in frameworks, not the KDE/4.7 branch.
(and yes, i'm aware of the good things we can do with this feature in works=
pace code :)
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103099/#review8082
-----------------------------------------------------------
On Nov. 9, 2011, 10:15 p.m., Anton Kreuzkamp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103099/
> -----------------------------------------------------------
> =
> (Updated Nov. 9, 2011, 10:15 p.m.)
> =
> =
> Review request for kdelibs and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> For KWin 4.8 Windows grouped using kwin's window tabbing feature, tell th=
e world outside kwin in which group they are, using an XProperty.
> This patch makes this XProperty accessable via NETWinInfo.
> I hope it will be possible to integrate it into the 4.7 branch for KDE r4=
.8.
> =
> =
> Diffs
> -----
> =
> kdeui/windowmanagement/netwm.h c64a0a5 =
> kdeui/windowmanagement/netwm.cpp cf28339 =
> kdeui/windowmanagement/netwm_def.h 1482bca =
> kdeui/windowmanagement/netwm_p.h d7f4599 =
> =
> Diff: http://git.reviewboard.kde.org/r/103099/diff/diff
> =
> =
> Testing
> -------
> =
> Tested with the methods/signals, tabGroup() and windowChanged(). Everythi=
ng I tested works.
> =
> =
> Thanks,
> =
> Anton Kreuzkamp
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103099/">http://git.reviewboard.kde.org/r/103099/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 10th, 2011, 10:02 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I would like to see this in kdelibs 4.8. It is a rather minor change and \
should be fine for 4.7 as well. But I don't know what's the state for \
additions to kdelibs currently...</pre> </blockquote>
<p>On November 10th, 2011, 10:19 a.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The freeze is today, \
which means it has to go in today.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a new feature. \
it is not needed to address any functionality bugs. so it belongs in frameworks, not \
the KDE/4.7 branch.
(and yes, i'm aware of the good things we can do with this feature in workspace \
code :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 9th, 2011, 10:15 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Martin Gräßlin.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2011, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For KWin 4.8 Windows grouped using kwin's window tabbing feature, \
tell the world outside kwin in which group they are, using an XProperty. This patch \
makes this XProperty accessable via NETWinInfo. I hope it will be possible to \
integrate it into the 4.7 branch for KDE r4.8.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the methods/signals, tabGroup() and windowChanged(). \
Everything I tested works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/netwm.h <span style="color: grey">(c64a0a5)</span></li>
<li>kdeui/windowmanagement/netwm.cpp <span style="color: grey">(cf28339)</span></li>
<li>kdeui/windowmanagement/netwm_def.h <span style="color: \
grey">(1482bca)</span></li>
<li>kdeui/windowmanagement/netwm_p.h <span style="color: grey">(d7f4599)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103099/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic