--===============6061817151722609728== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 10, 2011, 10:02 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > I would like to see this in kdelibs 4.8. It is a rather minor change an= d should be fine for 4.7 as well. But I don't know what's the state for add= itions to kdelibs currently... > = > Christoph Feck wrote: > The freeze is today, which means it has to go in today. this is a new feature. it is not needed to address any functionality bugs. = so it belongs in frameworks, not the KDE/4.7 branch. (and yes, i'm aware of the good things we can do with this feature in works= pace code :) - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103099/#review8082 ----------------------------------------------------------- On Nov. 9, 2011, 10:15 p.m., Anton Kreuzkamp wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103099/ > ----------------------------------------------------------- > = > (Updated Nov. 9, 2011, 10:15 p.m.) > = > = > Review request for kdelibs and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > For KWin 4.8 Windows grouped using kwin's window tabbing feature, tell th= e world outside kwin in which group they are, using an XProperty. > This patch makes this XProperty accessable via NETWinInfo. > I hope it will be possible to integrate it into the 4.7 branch for KDE r4= .8. > = > = > Diffs > ----- > = > kdeui/windowmanagement/netwm.h c64a0a5 = > kdeui/windowmanagement/netwm.cpp cf28339 = > kdeui/windowmanagement/netwm_def.h 1482bca = > kdeui/windowmanagement/netwm_p.h d7f4599 = > = > Diff: http://git.reviewboard.kde.org/r/103099/diff/diff > = > = > Testing > ------- > = > Tested with the methods/signals, tabGroup() and windowChanged(). Everythi= ng I tested works. > = > = > Thanks, > = > Anton Kreuzkamp > = > --===============6061817151722609728== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103099/

On November 10th, 2011, 10:02 a.m., Martin = Gr=C3=A4=C3=9Flin wrote:

I would l=
ike to see this in kdelibs 4.8. It is a rather minor change and should be f=
ine for 4.7 as well. But I don't know what's the state for addition=
s to kdelibs currently...

On November 10th, 2011, 10:19 a.m., Christoph Feck wrote:

The freez=
e is today, which means it has to go in today.
this is a n=
ew feature. it is not needed to address any functionality bugs. so it belon=
gs in frameworks, not the KDE/4.7 branch.

(and yes, i'm aware of the good things we can do with this feature in w=
orkspace code :)

- Aaron J.


On November 9th, 2011, 10:15 p.m., Anton Kreuzkamp wrote:

Review request for kdelibs and Martin Gr=C3=A4=C3=9Flin.
By Anton Kreuzkamp.

Updated Nov. 9, 2011, 10:15 p.m.

Descripti= on

For KWin 4.8 Windows grouped using kwin's window tabbing=
 feature, tell the world outside kwin in which group they are, using an XPr=
operty.
This patch makes this XProperty accessable via NETWinInfo.
I hope it will be possible to integrate it into the 4.7 branch for KDE r4.8=
.

Testing <= /h1>
Tested with the methods/signals, tabGroup() and windowChange=
d(). Everything I tested works.

Diffs=

  • kdeui/windowmanagement/netwm.h (c64a0a5)
  • kdeui/windowmanagement/netwm.cpp (cf28339)=
  • kdeui/windowmanagement/netwm_def.h (1482bc= a)
  • kdeui/windowmanagement/netwm_p.h (d7f4599)=

View Diff

--===============6061817151722609728==--