This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103099/

On November 10th, 2011, 10:02 a.m., Martin Gräßlin wrote:

I would like to see this in kdelibs 4.8. It is a rather minor change and should be fine for 4.7 as well. But I don't know what's the state for additions to kdelibs currently...

On November 10th, 2011, 10:19 a.m., Christoph Feck wrote:

The freeze is today, which means it has to go in today.
this is a new feature. it is not needed to address any functionality bugs. so it belongs in frameworks, not the KDE/4.7 branch.

(and yes, i'm aware of the good things we can do with this feature in workspace code :)

- Aaron J.


On November 9th, 2011, 10:15 p.m., Anton Kreuzkamp wrote:

Review request for kdelibs and Martin Gräßlin.
By Anton Kreuzkamp.

Updated Nov. 9, 2011, 10:15 p.m.

Description

For KWin 4.8 Windows grouped using kwin's window tabbing feature, tell the world outside kwin in which group they are, using an XProperty.
This patch makes this XProperty accessable via NETWinInfo.
I hope it will be possible to integrate it into the 4.7 branch for KDE r4.8.

Testing

Tested with the methods/signals, tabGroup() and windowChanged(). Everything I tested works.

Diffs

  • kdeui/windowmanagement/netwm.h (c64a0a5)
  • kdeui/windowmanagement/netwm.cpp (cf28339)
  • kdeui/windowmanagement/netwm_def.h (1482bca)
  • kdeui/windowmanagement/netwm_p.h (d7f4599)

View Diff