[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: new kded daemon to check .thumbnail directory
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-08-04 19:58:04
Message-ID: 20110804195804.28194.10271 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 4, 2011, 12:14 p.m., Christoph Feck wrote:
> > > it is missing the code to delete the files
> >
> > And I doubt we will be able to solve this.
> > * Delete thumbnails of files that are no longer present? I have \
> > thumbnails from files of external hard disks, and I rather would like \
> > to keep them when unmounting those disks.
> > * Delete thumbnails of files that are accessed long ago? My file \
> > systems are mounted in a way to not track read accesses, so it cannot \
> > know if a file has been recently used.
> > Instead of constantly deleting the wrong files, you could rather fire \
> > Sweeper and delete all of them. Being notified about the space issue is \
> > an improvement, though.
> > What I rather would like to see:
> > * Being able to manually browse/delete thumbnails by path: A \
> > thumbnail:// kioslave basically, that keeps the folder \
> > hierarchy.
> > * Integration with Nepomuk, so that thumbnails automatically get \
> > moved/deleted when the original file is.
> > Yes, this means not to use (or do a complete overhaul of) the thumbnail \
> > specs.
You are asking too much for this first approach..This is the first time I'm \
using KIO. I simply will remove the oldest files.
There is now no way to know if a file is in any of the two cases you \
present. But there are manually and complex workarounds.. file rights in \
the first case, and removing the noatime in the second.
I tried to present more than 3 buttons (delete, file manager, sweeper and \
config), but I only know how to handle the 3 first buttons.
Nepomuk, and thumbnail:// kioslave, next version. (You could talk about the \
specs in Berlin... I can not go this year also, but I've been closer).
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102083/#review5389
-----------------------------------------------------------
On July 25, 2011, 1:58 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102083/
> -----------------------------------------------------------
>
> (Updated July 25, 2011, 1:58 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This is not yet complete, it is missing the code to delete the files, \
> trailing spaces and comments in spanish. (coming in next patch version)
> There are also some things I'm not sure how should be done...
> The translations in .notifyrc and .desktop files, should be removed or \
> just keep the lines with an empty traslation? Classes names, method names \
> and variable names are OK?
>
> This addresses bug 79943.
> http://bugs.kde.org/show_bug.cgi?id=79943
>
>
> Diffs
> -----
>
> directoryusagenotifier/module.cpp PRE-CREATION
> directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION
> directoryusagenotifier/module.h PRE-CREATION
> directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION
> directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION
> directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION
> directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION
> directoryusagenotifier/Messages.sh PRE-CREATION
> directoryusagenotifier/README PRE-CREATION
> directoryusagenotifier/cleanupdirectory.h PRE-CREATION
> directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION
> directoryusagenotifier/directoryusagenotifier.h PRE-CREATION
> directoryusagenotifier/CMakeLists.txt PRE-CREATION
> directoryusagenotifier/COPYING PRE-CREATION
> CMakeLists.txt 89d97cd
> directoryusagenotifier/settings.kcfgc PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/102083/diff
>
>
> Testing
> -------
>
> It works as expected (except it does not yet clean the directory).
>
>
> Thanks,
>
> Jaime Torres
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102083/">http://git.reviewboard.kde.org/r/102083/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On August 4th, 2011, 12:14 \
p.m., <b>Christoph Feck</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> it is \
missing the code to delete the files
And I doubt we will be able to solve this.
* Delete thumbnails of files that are no longer present? I have thumbnails \
from files of external hard disks, and I rather would like to keep them \
when unmounting those disks.
* Delete thumbnails of files that are accessed long ago? My file systems \
are mounted in a way to not track read accesses, so it cannot know if a \
file has been recently used.
Instead of constantly deleting the wrong files, you could rather fire \
Sweeper and delete all of them. Being notified about the space issue is an \
improvement, though.
What I rather would like to see:
* Being able to manually browse/delete thumbnails by path: A thumbnail:// \
kioslave basically, that keeps the folder hierarchy.
* Integration with Nepomuk, so that thumbnails automatically get \
moved/deleted when the original file is.
Yes, this means not to use (or do a complete overhaul of) the thumbnail \
specs.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are asking \
too much for this first approach..This is the first time I'm using KIO. \
I simply will remove the oldest files. There is now no way to know if a \
file is in any of the two cases you present. But there are manually and \
complex workarounds.. file rights in the first case, and removing the \
noatime in the second.
I tried to present more than 3 buttons (delete, file manager, sweeper and \
config), but I only know how to handle the 3 first buttons.
Nepomuk, and thumbnail:// kioslave, next version. (You could talk about the \
specs in Berlin... I can not go this year also, but I've been closer). \
</pre> <br />
<p>- Jaime Torres</p>
<br />
<p>On July 25th, 2011, 1:58 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated July 25, 2011, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is not yet complete, it is missing the code to delete the \
files, trailing spaces and comments in spanish. (coming in next patch \
version)
There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just \
keep the lines with an empty traslation? Classes names, method names and \
variable names are OK? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works as expected (except it does not yet clean the \
directory). </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=79943">79943</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>directoryusagenotifier/module.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier_prefs_base.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/module.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.notifyrc <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/cleanupdirectory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/directoryusagenotifier.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>directoryusagenotifier/COPYING <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(89d97cd)</span></li>
<li>directoryusagenotifier/settings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102083/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic