This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/

On August 4th, 2011, 12:14 p.m., Christoph Feck wrote:

> it is missing the code to delete the files

And I doubt we will be able to solve this.
* Delete thumbnails of files that are no longer present? I have thumbnails from files of external hard disks, and I rather would like to keep them when unmounting those disks.
* Delete thumbnails of files that are accessed long ago? My file systems are mounted in a way to not track read accesses, so it cannot know if a file has been recently used.

Instead of constantly deleting the wrong files, you could rather fire Sweeper and delete all of them. Being notified about the space issue is an improvement, though.

What I rather would like to see:
* Being able to manually browse/delete thumbnails by path: A thumbnail:// kioslave basically, that keeps the folder hierarchy.
* Integration with Nepomuk, so that thumbnails automatically get moved/deleted when the original file is.

Yes, this means not to use (or do a complete overhaul of) the thumbnail specs.
You are asking too much for this first approach..This is the first time I'm using KIO.
I simply will remove the oldest files. 
There is now no way to know if a file is in any of the two cases you present. But there are manually and complex workarounds.. file rights in the first case, and removing the noatime in the second.

I tried to present more than 3 buttons (delete, file manager, sweeper and config), but I only know how to handle the 3 first buttons.

Nepomuk, and thumbnail:// kioslave, next version. (You could talk about the specs in Berlin... I can not go this year also, but I've been closer).

- Jaime Torres


On July 25th, 2011, 1:58 p.m., Jaime Torres Amate wrote:

Review request for kdelibs.
By Jaime Torres Amate.

Updated July 25, 2011, 1:58 p.m.

Description

This is not yet complete, it is missing the code to delete the files, trailing spaces and comments in spanish. (coming in next patch version)

There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just keep the lines with an empty traslation?
Classes names, method names and variable names are OK?

Testing

It works as expected (except it does not yet clean the directory).
Bugs: 79943

Diffs

  • directoryusagenotifier/module.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier_prefs_base.ui (PRE-CREATION)
  • directoryusagenotifier/module.h (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.notifyrc (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.desktop (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.kcfg (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.cpp (PRE-CREATION)
  • directoryusagenotifier/Messages.sh (PRE-CREATION)
  • directoryusagenotifier/README (PRE-CREATION)
  • directoryusagenotifier/cleanupdirectory.h (PRE-CREATION)
  • directoryusagenotifier/cleanupdirectory.cpp (PRE-CREATION)
  • directoryusagenotifier/directoryusagenotifier.h (PRE-CREATION)
  • directoryusagenotifier/CMakeLists.txt (PRE-CREATION)
  • directoryusagenotifier/COPYING (PRE-CREATION)
  • CMakeLists.txt (89d97cd)
  • directoryusagenotifier/settings.kcfgc (PRE-CREATION)

View Diff