This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102083/

On August 4th, 2011, 12:14 p.m., Christoph = Feck wrote:

> it i=
s missing the code to delete the files

And I doubt we will be able to solve this.
* Delete thumbnails of files that are no longer present? I have thumbnails =
from files of external hard disks, and I rather would like to keep them whe=
n unmounting those disks.
* Delete thumbnails of files that are accessed long ago? My file systems ar=
e mounted in a way to not track read accesses, so it cannot know if a file =
has been recently used.

Instead of constantly deleting the wrong files, you could rather fire Sweep=
er and delete all of them. Being notified about the space issue is an impro=
vement, though.

What I rather would like to see:
* Being able to manually browse/delete thumbnails by path: A thumbnail:// k=
ioslave basically, that keeps the folder hierarchy.
* Integration with Nepomuk, so that thumbnails automatically get moved/dele=
ted when the original file is.

Yes, this means not to use (or do a complete overhaul of) the thumbnail spe=
cs.

You are ask=
ing too much for this first approach..This is the first time I'm using =
KIO.
I simply will remove the oldest files. =

There is now no way to know if a file is in any of the two cases you presen=
t. But there are manually and complex workarounds.. file rights in the firs=
t case, and removing the noatime in the second.

I tried to present more than 3 buttons (delete, file manager, sweeper and c=
onfig), but I only know how to handle the 3 first buttons.

Nepomuk, and thumbnail:// kioslave, next version. (You could talk about the=
 specs in Berlin... I can not go this year also, but I've been closer).

- Jaime Torres

On July 25th, 2011, 1:58 p.m., Jaime Torres Amate wrote:

Review request for kdelibs.

By Jaime Torres Amate.

Updated July 25, 2011, 1:58 p.m.

Descripti= on

This is not yet complete, it is missing the code to delete t=
he files, trailing spaces and comments in spanish. (coming in next patch ve=
rsion)

There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just=
 keep the lines with an empty traslation?
Classes names, method names and variable names are OK?

Testing <= /h1>

It works as expected (except it does not yet clean the direc=
tory).

Bugs: 79943

Diffs=

directoryusagenotifier/module.cpp (PRE-CRE= ATION)
directoryusagenotifier/directoryusagenotifier_prefs_base.ui (PRE-CREATION)
directoryusagenotifier/module.h (PRE-CREAT= ION)
directoryusagenotifier/directoryusagenotifier.notifyrc (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.desktop (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.kcfg (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.cpp (PRE-CREATION)
directoryusagenotifier/Messages.sh (PRE-CR= EATION)
directoryusagenotifier/README (PRE-CREATIO= N)
directoryusagenotifier/cleanupdirectory.h = (PRE-CREATION)
directoryusagenotifier/cleanupdirectory.cpp (PRE-CREATION)
directoryusagenotifier/CMakeLists.txt (PRE= -CREATION)
directoryusagenotifier/COPYING (PRE-CREATI= ON)
CMakeLists.txt (89d97cd)
directoryusagenotifier/settings.kcfgc (PRE= -CREATION)

View Diff

Descripti= on

Testing <= /h1> It works as expected (except it does not yet clean the direc= tory). Bugs: 79943

Diffs=

Testing <= /h1>

It works as expected (except it does not yet clean the direc= tory).

Bugs: 79943