From kde-core-devel Thu Apr 21 02:50:47 2011 From: "Dawit Alemayehu" Date: Thu, 21 Apr 2011 02:50:47 +0000 To: kde-core-devel Subject: Re: Review Request: Do not preserve username information on Message-Id: <20110421025047.22355.93949 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130335428104861 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8252813368217982836==" --===============8252813368217982836== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101153/ ----------------------------------------------------------- (Updated April 21, 2011, 2:50 a.m.) Review request for kdelibs and David Faure. Summary (updated) ------- This patch completely removes the automatic restoration of the user name fr= om the original url to the redirection url at the job level. Even though I = tried to lookup why this was done a long time ago, I have not been able to = decipher the reason behind it. I could only guess that it was probably done= as a workaround for the deficiencies of some unknown ioslave that was not = doing the right thing when constructing the redirection url. Unfortunately this has now come in full circle to cause problems when attem= pting to fix kio_ftp's login related bug reports. Namely I wanted to fix th= e problem where the user typed a username as part of the ftp url and later = on either changed it or choose to login anonymously when prompted with a pa= ssword dialog. Right now the client never gets updated even when the user c= hose to use a different username in the password dialog. IOW, the username = reflected in the typed-in url is different from the one the user used to lo= gin. You can guess what happens when the user then clicks on a folder or fi= le after logging in. The process I chose to use to update the client is to cause a redirection a= nd that works fine so long as the redirection url contains a proper usernam= e. Otherwise, the redirection handling slots in KIO::Job automatically re-i= nsert the username from the old url into the new redirection url. Diffs ----- kio/kio/job.cpp 004b4c9 = Diff: http://git.reviewboard.kde.org/r/101153/diff Testing ------- Thanks, Dawit --===============8252813368217982836== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101153/

Review request for kdelibs and David Faure.
By Dawit Alemayehu.

Updated April 21, 2011, 2:50 a.m.

Descripti= on (updated)

This patch completely removes the automatic restoration of t=
he user name from the original url to the redirection url at the job level.=
 Even though I tried to lookup why this was done a long time ago, I have no=
t been able to decipher the reason behind it. I could only guess that it wa=
s probably done as a workaround for the deficiencies of some unknown ioslav=
e that was not doing the right thing when constructing the redirection url.

Unfortunately this has now come in full circle to cause problems when attem=
pting to fix kio_ftp's login related bug reports. Namely I wanted to fi=
x the problem where the user typed a username as part of the ftp url and la=
ter on either changed it or choose to login anonymously when prompted with =
a password dialog. Right now the client never gets updated even when the us=
er chose to use a different username in the password dialog. IOW, the usern=
ame reflected in the typed-in url is different from the one the user used t=
o login. You can guess what happens when the user then clicks on a folder o=
r file after logging in.

The process I chose to use to update the client is to cause a redirection a=
nd that works fine so long as the redirection url contains a proper usernam=
e. Otherwise, the redirection handling slots in KIO::Job automatically re-i=
nsert the username from the old url into the new redirection url.

Diffs=

  • kio/kio/job.cpp (004b4c9)

View Diff
--===============8252813368217982836==--