[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: GUI configuration for the 'Do Not Track'
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-19 3:53:17
Message-ID: 20110419035317.31617.42726 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101124/#review2745
-----------------------------------------------------------
This review has been submitted with commit 5daad5fc120c00a69f312bd7f868c346=
0ef78a5b by Dawit Alemayehu.
- Commit
On April 17, 2011, 4:22 p.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101124/
> -----------------------------------------------------------
> =
> (Updated April 17, 2011, 4:22 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> The attach patch adds GUI configuration for the 'Do Not Track' feature th=
at has just been implemented in kio_http[1]. Support for the Do Not Track f=
unctionality exists in almost all of the recent versions of the major brows=
ers. The draft spec for this feature can be found at http://www.ietf.org/id=
/draft-mayer-do-not-track-00.txt. =
> =
> [1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f5588375=
53
> =
> Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any =
objections, insights, suggestions are all welcome before I commit this.
> =
> =
> Diffs
> -----
> =
> konqueror/settings/konqhtml/htmlopts.h b0faf0d =
> konqueror/settings/konqhtml/htmlopts.cpp 1ca17cb =
> =
> Diff: http://git.reviewboard.kde.org/r/101124/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> screenshot
> http://git.reviewboard.kde.org/r/101124/s/130/
> =
> =
> Thanks,
> =
> Dawit
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101124/">http://git.reviewboard.kde.org/r/101124/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5daad5fc120c00a69f312bd7f868c3460ef78a5b by Dawit \
Alemayehu.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 17th, 2011, 4:22 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 17, 2011, 4:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attach patch adds GUI configuration for the 'Do Not Track' \
feature that has just been implemented in kio_http[1]. Support for the Do Not Track \
functionality exists in almost all of the recent versions of the major browsers. The \
draft spec for this feature can be found at \
http://www.ietf.org/id/draft-mayer-do-not-track-00.txt.
[1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f558837553
Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any objections, \
insights, suggestions are all welcome before I commit this.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/konqhtml/htmlopts.h <span style="color: \
grey">(b0faf0d)</span></li>
<li>konqueror/settings/konqhtml/htmlopts.cpp <span style="color: \
grey">(1ca17cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101124/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101124/s/130/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/17/dnt_ui_implementation_1_400x100.png" \
style="border: 1px black solid;" alt="screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic