[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: fix broken nepomuk ui files to make messages
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2011-04-13 14:04:26
Message-ID: 20110413140426.481.48958 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101112/
-----------------------------------------------------------
Review request for KDE Runtime and Sebastian Trueg.
Summary
-------
Some nepomuk ui files have strings like <string extracomment="@info">some \
message</string> xgettext extracts this properly to msgctxt "@info" msgid "some \
message" ui compiler generates tr2i18n("some message", 0) -> that does not match \
xgettext, therefore no translated msg is found
With <string comment="@info">some message</string>
the ui compiler generates tr2i18n("some message", "@info"), that does match xgettext \
and the translated msg is found and shown
Diffs
-----
nepomuk/kcm/nepomukconfigwidget.ui 5652274
nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5
nepomuk/services/backupsync/gui/intropage.ui 1a74630
nepomuk/services/backupsync/gui/restoreselection.ui 157c50a
Diff: http://git.reviewboard.kde.org/r/101112/diff
Testing
-------
Tested using locale x-test \
(http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), \
messages are translated
Thanks,
Burkhard
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101112/">http://git.reviewboard.kde.org/r/101112/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Sebastian Trueg.</div>
<div>By Burkhard Lück.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some nepomuk ui files have strings like <string \
extracomment="@info">some message</string> xgettext extracts this \
properly to msgctxt "@info" msgid "some message" ui compiler \
generates tr2i18n("some message", 0) -> that does not match xgettext, \
therefore no translated msg is found
With <string comment="@info">some message</string>
the ui compiler generates tr2i18n("some message", "@info"), that \
does match xgettext and the translated msg is found and shown</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested using locale x-test \
(http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), \
messages are translated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/nepomukconfigwidget.ui <span style="color: \
grey">(5652274)</span></li>
<li>nepomuk/services/backupsync/gui/backupsettingspage.ui <span style="color: \
grey">(e28a7f5)</span></li>
<li>nepomuk/services/backupsync/gui/intropage.ui <span style="color: \
grey">(1a74630)</span></li>
<li>nepomuk/services/backupsync/gui/restoreselection.ui <span style="color: \
grey">(157c50a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101112/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic