From kde-core-devel Wed Apr 13 14:04:26 2011 From: =?utf-8?q?Burkhard_L=C3=BCck?= Date: Wed, 13 Apr 2011 14:04:26 +0000 To: kde-core-devel Subject: Review Request: fix broken nepomuk ui files to make messages Message-Id: <20110413140426.481.48958 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130270351629337 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9114675896394340580==" --===============9114675896394340580== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/ ----------------------------------------------------------- Review request for KDE Runtime and Sebastian Trueg. Summary ------- Some nepomuk ui files have strings like some= message xgettext extracts this properly to msgctxt "@info" msgid "some message" ui compiler generates tr2i18n("some message", 0) -> that does not match xge= ttext, therefore no translated msg is found With some message the ui compiler generates tr2i18n("some message", "@info"), that does match= xgettext and the translated msg is found and shown Diffs ----- nepomuk/kcm/nepomukconfigwidget.ui 5652274 = nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 = nepomuk/services/backupsync/gui/intropage.ui 1a74630 = nepomuk/services/backupsync/gui/restoreselection.ui 157c50a = Diff: http://git.reviewboard.kde.org/r/101112/diff Testing ------- Tested using locale x-test (http://techbase.kde.org/Development/Tutorials/L= ocalization/Building_KDE's_l10n_Module), = messages are translated Thanks, Burkhard --===============9114675896394340580== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101112/

Review request for KDE Runtime and Sebastian Trueg.

By Burkhard L=C3=BCck.

Descripti= on

Some nepomuk ui files have strings like <string extracomm=
ent=3D"@info">some message</string>
xgettext extracts this properly to msgctxt "@info" msgid "so=
me message"
ui compiler generates tr2i18n("some message", 0) -> that does =
not match xgettext, therefore no translated msg is found

With <string comment=3D"@info">some message</string>
the ui compiler generates tr2i18n("some message", "@info&quo=
t;), that does match xgettext and the translated msg is found and shown

Testing <= /h1>

Tested using locale x-test (http://techbase.kde.org/Developm=
ent/Tutorials/Localization/Building_KDE's_l10n_Module), =

messages are translated

Diffs=

nepomuk/kcm/nepomukconfigwidget.ui (565227= 4)
nepomuk/services/backupsync/gui/backupsettingspage.ui (e28a7f5)
nepomuk/services/backupsync/gui/intropage.ui (1a74630)
nepomuk/services/backupsync/gui/restoreselection.ui (157c50a)

--===============9114675896394340580==--