[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adding =?utf-8?q?=C3=85ngstr=C3=B6m_to?=
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2011-03-23 19:19:47
Message-ID: 201103232019.48450 () thufir ! ingo-kloecker ! de
[Download RAW message or body]


On Wednesday 23 March 2011, Johannes Sixt wrote:
> Am 3/22/2011 23:14, schrieb Parker Coates:
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/100923/
> > 
> > 
> > kunitconversion/length.cpp
> > <http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file126
> > 95line146> (Diff revision 1)
> > 
> > Length::Length() : UnitCategory(LengthCategory)
> > 
> > 	146
> > 	
> >       i18nc("unit synonyms for matching user input",
> >       "Ångström;Ångstrom;Angström,Å"),
> 
> What is the encoding of this string? What is the encoding of the
> source file? I guess this is a latin1 string;

No. All of KDE's source code uses utf-8.


> shouldn't you better write the string as
> 
> "\xc5ngstr\xf6m;\xc5ngstrom;Angstr\xf6m;Angstrom;\xc5"
> 
> to avoid any encoding errors? (Also, did you mean ; instead of ,
> before the final Å?)

Yes, that's definitely safer than using non-ASCII character in source 
code.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]